You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2002/04/11 21:09:05 UTC
cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve ValveUtil.java
manveen 02/04/11 12:09:05
Modified: webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve
ValveUtil.java
Log:
* "create" operationName depends on valve type (Minor fixes).
* Changed description of class.
Revision Changes Path
1.2 +10 -13 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java
Index: ValveUtil.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ValveUtil.java 11 Apr 2002 07:42:04 -0000 1.1
+++ ValveUtil.java 11 Apr 2002 19:09:05 -0000 1.2
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v 1.1 2002/04/11 07:42:04 manveen Exp $
- * $Revision: 1.1 $
- * $Date: 2002/04/11 07:42:04 $
+ * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/ValveUtil.java,v 1.2 2002/04/11 19:09:05 manveen Exp $
+ * $Revision: 1.2 $
+ * $Date: 2002/04/11 19:09:05 $
*
* ====================================================================
*
@@ -91,11 +91,10 @@
import org.apache.webapp.admin.logger.DeleteLoggerAction;
/**
- * The <code>Action</code> that completes <em>Add Valve</em> and
- * <em>Edit Valve</em> transactions for Remote Addr valve.
+ * A utility class that contains methods common across valves.
*
* @author Manveen Kaur
- * @version $Revision: 1.1 $ $Date: 2002/04/11 07:42:04 $
+ * @version $Revision: 1.2 $ $Date: 2002/04/11 19:09:05 $
*/
public final class ValveUtil {
@@ -165,10 +164,9 @@
if (mBServer.isRegistered(oname)) {
ActionErrors errors = new ActionErrors();
errors.add("valveName",
- new ActionError("error.valveName.exists"));
+ new ActionError("error.valveName.exists"));
String message =
- resources.getMessage("error.valveName.exists",
- sb.toString());
+ resources.getMessage("error.valveName.exists", sb.toString());
response.sendError(HttpServletResponse.SC_BAD_REQUEST, message);
//saveErrors(request, errors);
return (new ActionForward(mapping.getInput()));
@@ -181,10 +179,9 @@
// Create a new StandardValve object
values = new String[1];
values[0] = parent;
- operation = "createValve";
+ operation = "create" + valveType;
String vObjectName = (String)
- mBServer.invoke(fname, operation,
- values, createStandardValveTypes);
+ mBServer.invoke(fname, operation, values, createStandardValveTypes);
// Add the new Valve to our tree control node
TreeControl control = (TreeControl)
@@ -193,7 +190,7 @@
TreeControlNode parentNode = control.findNode(parent);
if (parentNode != null) {
String nodeLabel =
- "Valve (" + valveType + ")";
+ "Valve for " + parentNode.getLabel();
String encodedName =
URLEncoder.encode(vObjectName);
TreeControlNode childNode =
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>