You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Angela Schreiber (Jira)" <ji...@apache.org> on 2022/08/09 15:19:00 UTC

[jira] [Created] (OAK-9892) Improve query statement for ExternalGroupPrincipalProvider.findPrincipals

Angela Schreiber created OAK-9892:
-------------------------------------

             Summary: Improve query statement for ExternalGroupPrincipalProvider.findPrincipals
                 Key: OAK-9892
                 URL: https://issues.apache.org/jira/browse/OAK-9892
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: auth-external
            Reporter: Angela Schreiber
            Assignee: Angela Schreiber
             Fix For: 1.46.0


when reviewing the queries in _oak-auth-external_ [~thomasm] noticed that query statement in {{ExternalGroupPrincipalProvider#findPrincipals}} is not correct (though working). instead of 

{code}
String statement = "SELECT '" + REP_EXTERNAL_PRINCIPAL_NAMES + "' FROM [rep:User] WHERE PROPERTY(["
                    + REP_EXTERNAL_PRINCIPAL_NAMES + "], '" + PropertyType.TYPENAME_STRING + "')"
                    + op + "$" + BINDING_PRINCIPAL_NAMES + QueryEngine.INTERNAL_SQL2_QUERY;
{code}

it should rather be

{code}
String statement = "SELECT [" + REP_EXTERNAL_PRINCIPAL_NAMES + "] FROM [rep:User] WHERE PROPERTY(["
                    + REP_EXTERNAL_PRINCIPAL_NAMES + "], '" + PropertyType.TYPENAME_STRING + "')"
                    + op + "$" + BINDING_PRINCIPAL_NAMES + QueryEngine.INTERNAL_SQL2_QUERY;
{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)