You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2025/08/14 07:21:53 UTC
[PR] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
JiriOndrusek opened a new pull request, #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634
partially fixes https://github.com/apache/camel-quarkus/issues/7396 (for postgress, mongodb, mysql)
I plan to continue with oracle and mssql native failures in the next PR
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276220738
##########
extensions-support/debezium/deployment/src/main/java/org/apache/camel/quarkus/support/debezium/deployment/DebeziumSupportProcessor.java:
##########
@@ -24,45 +50,104 @@
import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
import org.apache.kafka.common.security.authenticator.SaslClientAuthenticator;
+import org.apache.kafka.connect.json.JsonConverter;
+import org.apache.kafka.connect.source.SourceTask;
+import org.jboss.jandex.DotName;
import org.jboss.jandex.IndexView;
public class DebeziumSupportProcessor {
@BuildStep
- ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex) {
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(SaslClientAuthenticator.class.getName());
+ }
+
+ @BuildStep
+ void reflectiveClasses(CombinedIndexBuildItem combinedIndex, BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
IndexView index = combinedIndex.getIndex();
String[] dtos = index.getKnownClasses().stream().map(ci -> ci.name().toString())
.filter(n -> n.startsWith("org.apache.kafka.connect.json")
|| n.startsWith("io.debezium.engine.spi"))
.sorted()
.toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- return ReflectiveClassBuildItem.builder(dtos).fields().build();
- }
+ dtos = index.getAllKnownImplementations(DotName.createSimple(SnapshotLock.class.getName())).stream()
+ .map(ci -> ci.name().toString())
+ .sorted()
+ .toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- @BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { "org.apache.kafka.connect.storage.FileOffsetBackingStore",
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ "org.apache.kafka.connect.storage.FileOffsetBackingStore",
"org.apache.kafka.connect.storage.MemoryOffsetBackingStore",
+ "io.debezium.storage.kafka.history.KafkaSchemaHistory",
"io.debezium.relational.history.FileDatabaseHistory",
- "io.debezium.embedded.ConvertingEngineBuilderFactory" }).build();
- }
+ "io.debezium.embedded.ConvertingEngineBuilderFactory",
+ "io.debezium.processors.PostProcessorRegistry",
+ "io.debezium.pipeline.txmetadata.DefaultTransactionMetadataFactory",
+ "io.debezium.schema.SchemaTopicNamingStrategy",
+ "io.debezium.storage.file.history.FileSchemaHistory")
+ .build());
- @BuildStep
- void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
- indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
- indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ DebeziumEngine.BuilderFactory.class,
+ ConvertingAsyncEngineBuilderFactory.class,
+ SaslClientAuthenticator.class,
+ JsonConverter.class,
+ DefaultTransactionMetadataFactory.class,
+ SchemaTopicNamingStrategy.class,
+ BaseSourceTask.class,
+ SinkNotificationChannel.class,
+ LogNotificationChannel.class,
+ JmxNotificationChannel.class,
+ SnapshotLock.class,
+ NoLockingSupport.class,
+ AlwaysSnapshotter.class,
+ InitialSnapshotter.class,
+ InitialOnlySnapshotter.class,
+ NoDataSnapshotter.class,
+ RecoverySnapshotter.class,
+ WhenNeededSnapshotter.class,
+ NeverSnapshotter.class,
+ SchemaOnlySnapshotter.class,
+ SchemaOnlyRecoverySnapshotter.class,
+ ConfigurationBasedSnapshotter.class,
+ SourceSignalChannel.class,
+ KafkaSignalChannel.class,
+ FileSignalChannel.class,
+ JmxSignalChannel.class,
+ InProcessSignalChannel.class,
+ StandardActionProvider.class,
+ SourceTask.class)
+ .build());
}
- @BuildStep
- void registerServiceProviders(BuildProducer<NativeImageResourceBuildItem> nativeImage) {
- nativeImage.produce(
+ @BuildStep()
+ void registerNativeImageResources(BuildProducer<NativeImageResourceBuildItem> resources) {
+ resources.produce(new NativeImageResourceBuildItem(
+ "META-INF/services/io.debezium.embedded.async.ConvertingAsyncEngineBuilderFactory"));
+ resources.produce(
new NativeImageResourceBuildItem("META-INF/services/io.debezium.engine.DebeziumEngine$BuilderFactory"));
- }
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
Review Comment:
I'll refactor it as you suggest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native (except Oracle) [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3192267274
CI is greenπ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276860445
##########
debezium-grouped-native.log:
##########
@@ -0,0 +1 @@
+[INFO] Scanning for projects...
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3188764097
@jamesnetherton There is one thing I'm not sure about:
- the mssal test requires MySQL connector-j(see https://github.com/apache/camel-quarkus/blob/main/integration-test-groups/debezium/mssql/pom.xml#L51)
- the library does not work in the native as is. I had to do som substitution and runtime registration.
I don't think that the code belongs to debezium-mssql, so I created a new module `extesnion-support/mysql-connector`.
I'm not sure about the location, If you think that there might be a better place, I'll refactor it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native (except Oracle) [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276219167
##########
debezium-grouped-native.log:
##########
@@ -0,0 +1 @@
+[INFO] Scanning for projects...
Review Comment:
sure, I missed that:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3188744538
@jamesnetherton
I updated the PR with the native support of mssql, mysql and oravle.
Though there is a small issue with oracle when the `debezium-grouped` is executed, reported as https://github.com/apache/camel-quarkus/issues/7638
I think that this PR can be merged (once CI confirms the status)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276818803
##########
extensions-support/debezium/deployment/src/main/java/org/apache/camel/quarkus/support/debezium/deployment/DebeziumSupportProcessor.java:
##########
@@ -24,45 +50,104 @@
import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
import org.apache.kafka.common.security.authenticator.SaslClientAuthenticator;
+import org.apache.kafka.connect.json.JsonConverter;
+import org.apache.kafka.connect.source.SourceTask;
+import org.jboss.jandex.DotName;
import org.jboss.jandex.IndexView;
public class DebeziumSupportProcessor {
@BuildStep
- ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex) {
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(SaslClientAuthenticator.class.getName());
+ }
+
+ @BuildStep
+ void reflectiveClasses(CombinedIndexBuildItem combinedIndex, BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
IndexView index = combinedIndex.getIndex();
String[] dtos = index.getKnownClasses().stream().map(ci -> ci.name().toString())
.filter(n -> n.startsWith("org.apache.kafka.connect.json")
|| n.startsWith("io.debezium.engine.spi"))
.sorted()
.toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- return ReflectiveClassBuildItem.builder(dtos).fields().build();
- }
+ dtos = index.getAllKnownImplementations(DotName.createSimple(SnapshotLock.class.getName())).stream()
+ .map(ci -> ci.name().toString())
+ .sorted()
+ .toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- @BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { "org.apache.kafka.connect.storage.FileOffsetBackingStore",
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ "org.apache.kafka.connect.storage.FileOffsetBackingStore",
"org.apache.kafka.connect.storage.MemoryOffsetBackingStore",
+ "io.debezium.storage.kafka.history.KafkaSchemaHistory",
"io.debezium.relational.history.FileDatabaseHistory",
- "io.debezium.embedded.ConvertingEngineBuilderFactory" }).build();
- }
+ "io.debezium.embedded.ConvertingEngineBuilderFactory",
+ "io.debezium.processors.PostProcessorRegistry",
+ "io.debezium.pipeline.txmetadata.DefaultTransactionMetadataFactory",
+ "io.debezium.schema.SchemaTopicNamingStrategy",
+ "io.debezium.storage.file.history.FileSchemaHistory")
+ .build());
- @BuildStep
- void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
- indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
- indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ DebeziumEngine.BuilderFactory.class,
+ ConvertingAsyncEngineBuilderFactory.class,
+ SaslClientAuthenticator.class,
+ JsonConverter.class,
+ DefaultTransactionMetadataFactory.class,
+ SchemaTopicNamingStrategy.class,
+ BaseSourceTask.class,
+ SinkNotificationChannel.class,
+ LogNotificationChannel.class,
+ JmxNotificationChannel.class,
+ SnapshotLock.class,
+ NoLockingSupport.class,
+ AlwaysSnapshotter.class,
+ InitialSnapshotter.class,
+ InitialOnlySnapshotter.class,
+ NoDataSnapshotter.class,
+ RecoverySnapshotter.class,
+ WhenNeededSnapshotter.class,
+ NeverSnapshotter.class,
+ SchemaOnlySnapshotter.class,
+ SchemaOnlyRecoverySnapshotter.class,
+ ConfigurationBasedSnapshotter.class,
+ SourceSignalChannel.class,
+ KafkaSignalChannel.class,
+ FileSignalChannel.class,
+ JmxSignalChannel.class,
+ InProcessSignalChannel.class,
+ StandardActionProvider.class,
+ SourceTask.class)
+ .build());
}
- @BuildStep
- void registerServiceProviders(BuildProducer<NativeImageResourceBuildItem> nativeImage) {
- nativeImage.produce(
+ @BuildStep()
+ void registerNativeImageResources(BuildProducer<NativeImageResourceBuildItem> resources) {
+ resources.produce(new NativeImageResourceBuildItem(
+ "META-INF/services/io.debezium.embedded.async.ConvertingAsyncEngineBuilderFactory"));
+ resources.produce(
new NativeImageResourceBuildItem("META-INF/services/io.debezium.engine.DebeziumEngine$BuilderFactory"));
- }
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
Review Comment:
@jamesnetherton I've just relized that the `META-INF/services/io.debezium.embedded.async.ConvertingAsyncEngineBuilderFactory` is a better sokution.
In case the app contains only `debezium-postgresql' the file contains i.e.
```
io.debezium.connector.postgresql.snapshot.lock.NoSnapshotLock
io.debezium.connector.postgresql.snapshot.lock.SharedSnapshotLock
```
the same file for debezium oracle contains
```
io.debezium.connector.oracle.snapshot.lock.NoSnapshotLock
io.debezium.connector.oracle.snapshot.lock.SharedSnapshotLock
```
therefore we an keel those `META-INF` in debezium-support or we can list all services for each flavor of debezium.
What do you prefer?
I'd say that keeping meta-inf files (as is) would cause small number of issues, I'd say....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276846825
##########
extensions-support/debezium/deployment/src/main/java/org/apache/camel/quarkus/support/debezium/deployment/DebeziumSupportProcessor.java:
##########
@@ -24,45 +50,104 @@
import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
import org.apache.kafka.common.security.authenticator.SaslClientAuthenticator;
+import org.apache.kafka.connect.json.JsonConverter;
+import org.apache.kafka.connect.source.SourceTask;
+import org.jboss.jandex.DotName;
import org.jboss.jandex.IndexView;
public class DebeziumSupportProcessor {
@BuildStep
- ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex) {
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(SaslClientAuthenticator.class.getName());
+ }
+
+ @BuildStep
+ void reflectiveClasses(CombinedIndexBuildItem combinedIndex, BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
IndexView index = combinedIndex.getIndex();
String[] dtos = index.getKnownClasses().stream().map(ci -> ci.name().toString())
.filter(n -> n.startsWith("org.apache.kafka.connect.json")
|| n.startsWith("io.debezium.engine.spi"))
.sorted()
.toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- return ReflectiveClassBuildItem.builder(dtos).fields().build();
- }
+ dtos = index.getAllKnownImplementations(DotName.createSimple(SnapshotLock.class.getName())).stream()
+ .map(ci -> ci.name().toString())
+ .sorted()
+ .toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- @BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { "org.apache.kafka.connect.storage.FileOffsetBackingStore",
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ "org.apache.kafka.connect.storage.FileOffsetBackingStore",
"org.apache.kafka.connect.storage.MemoryOffsetBackingStore",
+ "io.debezium.storage.kafka.history.KafkaSchemaHistory",
"io.debezium.relational.history.FileDatabaseHistory",
- "io.debezium.embedded.ConvertingEngineBuilderFactory" }).build();
- }
+ "io.debezium.embedded.ConvertingEngineBuilderFactory",
+ "io.debezium.processors.PostProcessorRegistry",
+ "io.debezium.pipeline.txmetadata.DefaultTransactionMetadataFactory",
+ "io.debezium.schema.SchemaTopicNamingStrategy",
+ "io.debezium.storage.file.history.FileSchemaHistory")
+ .build());
- @BuildStep
- void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
- indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
- indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ DebeziumEngine.BuilderFactory.class,
+ ConvertingAsyncEngineBuilderFactory.class,
+ SaslClientAuthenticator.class,
+ JsonConverter.class,
+ DefaultTransactionMetadataFactory.class,
+ SchemaTopicNamingStrategy.class,
+ BaseSourceTask.class,
+ SinkNotificationChannel.class,
+ LogNotificationChannel.class,
+ JmxNotificationChannel.class,
+ SnapshotLock.class,
+ NoLockingSupport.class,
+ AlwaysSnapshotter.class,
+ InitialSnapshotter.class,
+ InitialOnlySnapshotter.class,
+ NoDataSnapshotter.class,
+ RecoverySnapshotter.class,
+ WhenNeededSnapshotter.class,
+ NeverSnapshotter.class,
+ SchemaOnlySnapshotter.class,
+ SchemaOnlyRecoverySnapshotter.class,
+ ConfigurationBasedSnapshotter.class,
+ SourceSignalChannel.class,
+ KafkaSignalChannel.class,
+ FileSignalChannel.class,
+ JmxSignalChannel.class,
+ InProcessSignalChannel.class,
+ StandardActionProvider.class,
+ SourceTask.class)
+ .build());
}
- @BuildStep
- void registerServiceProviders(BuildProducer<NativeImageResourceBuildItem> nativeImage) {
- nativeImage.produce(
+ @BuildStep()
+ void registerNativeImageResources(BuildProducer<NativeImageResourceBuildItem> resources) {
+ resources.produce(new NativeImageResourceBuildItem(
+ "META-INF/services/io.debezium.embedded.async.ConvertingAsyncEngineBuilderFactory"));
+ resources.produce(
new NativeImageResourceBuildItem("META-INF/services/io.debezium.engine.DebeziumEngine$BuilderFactory"));
- }
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
Review Comment:
We could maybe have common code in `debezium-support` and use `ServiceProviderBuildItem.allProvidersFromClassPath` for `ConvertingAsyncEngineBuilderFactory ` etc. That way it'd work for both Postgres and Oracle.
https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/builditem/nativeimage/ServiceProviderBuildItem.java#L78C44-L78C69
I don't want to over complicate things. So if you think it's better to keep things as-is, then lets do that and we can optimize later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276860356
##########
extensions-support/debezium/deployment/src/main/java/org/apache/camel/quarkus/support/debezium/deployment/DebeziumSupportProcessor.java:
##########
@@ -24,45 +50,104 @@
import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
import org.apache.kafka.common.security.authenticator.SaslClientAuthenticator;
+import org.apache.kafka.connect.json.JsonConverter;
+import org.apache.kafka.connect.source.SourceTask;
+import org.jboss.jandex.DotName;
import org.jboss.jandex.IndexView;
public class DebeziumSupportProcessor {
@BuildStep
- ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex) {
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(SaslClientAuthenticator.class.getName());
+ }
+
+ @BuildStep
+ void reflectiveClasses(CombinedIndexBuildItem combinedIndex, BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
IndexView index = combinedIndex.getIndex();
String[] dtos = index.getKnownClasses().stream().map(ci -> ci.name().toString())
.filter(n -> n.startsWith("org.apache.kafka.connect.json")
|| n.startsWith("io.debezium.engine.spi"))
.sorted()
.toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- return ReflectiveClassBuildItem.builder(dtos).fields().build();
- }
+ dtos = index.getAllKnownImplementations(DotName.createSimple(SnapshotLock.class.getName())).stream()
+ .map(ci -> ci.name().toString())
+ .sorted()
+ .toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- @BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { "org.apache.kafka.connect.storage.FileOffsetBackingStore",
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ "org.apache.kafka.connect.storage.FileOffsetBackingStore",
"org.apache.kafka.connect.storage.MemoryOffsetBackingStore",
+ "io.debezium.storage.kafka.history.KafkaSchemaHistory",
"io.debezium.relational.history.FileDatabaseHistory",
- "io.debezium.embedded.ConvertingEngineBuilderFactory" }).build();
- }
+ "io.debezium.embedded.ConvertingEngineBuilderFactory",
+ "io.debezium.processors.PostProcessorRegistry",
+ "io.debezium.pipeline.txmetadata.DefaultTransactionMetadataFactory",
+ "io.debezium.schema.SchemaTopicNamingStrategy",
+ "io.debezium.storage.file.history.FileSchemaHistory")
+ .build());
- @BuildStep
- void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
- indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
- indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ DebeziumEngine.BuilderFactory.class,
+ ConvertingAsyncEngineBuilderFactory.class,
+ SaslClientAuthenticator.class,
+ JsonConverter.class,
+ DefaultTransactionMetadataFactory.class,
+ SchemaTopicNamingStrategy.class,
+ BaseSourceTask.class,
+ SinkNotificationChannel.class,
+ LogNotificationChannel.class,
+ JmxNotificationChannel.class,
+ SnapshotLock.class,
+ NoLockingSupport.class,
+ AlwaysSnapshotter.class,
+ InitialSnapshotter.class,
+ InitialOnlySnapshotter.class,
+ NoDataSnapshotter.class,
+ RecoverySnapshotter.class,
+ WhenNeededSnapshotter.class,
+ NeverSnapshotter.class,
+ SchemaOnlySnapshotter.class,
+ SchemaOnlyRecoverySnapshotter.class,
+ ConfigurationBasedSnapshotter.class,
+ SourceSignalChannel.class,
+ KafkaSignalChannel.class,
+ FileSignalChannel.class,
+ JmxSignalChannel.class,
+ InProcessSignalChannel.class,
+ StandardActionProvider.class,
+ SourceTask.class)
+ .build());
}
- @BuildStep
- void registerServiceProviders(BuildProducer<NativeImageResourceBuildItem> nativeImage) {
- nativeImage.produce(
+ @BuildStep()
+ void registerNativeImageResources(BuildProducer<NativeImageResourceBuildItem> resources) {
+ resources.produce(new NativeImageResourceBuildItem(
+ "META-INF/services/io.debezium.embedded.async.ConvertingAsyncEngineBuilderFactory"));
+ resources.produce(
new NativeImageResourceBuildItem("META-INF/services/io.debezium.engine.DebeziumEngine$BuilderFactory"));
- }
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
Review Comment:
> Is it ok for you
Ok π.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276221197
##########
extensions/debezium-mongodb/deployment/src/main/java/org/apache/camel/quarkus/component/debezium/mongodb/deployment/DebeziumMongodbProcessor.java:
##########
@@ -32,8 +37,18 @@ FeatureBuildItem feature() {
}
@BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { MongoDbConnector.class.getName(),
- MongoDbConnectorTask.class.getName() }).build();
+ void reflectiveClasses(BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
+
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ MongoDbConnector.class,
+ MongoDbConnectorTask.class,
+ MongoDbSourceInfoStructMaker.class,
+ DefaultMongoDbAuthProvider.class,
+ SelectAllSnapshotQuery.class).build());
+ }
+
+ @BuildStep
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-connector-mongodb"));
Review Comment:
yes, correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276857029
##########
extensions-support/debezium/deployment/src/main/java/org/apache/camel/quarkus/support/debezium/deployment/DebeziumSupportProcessor.java:
##########
@@ -24,45 +50,104 @@
import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
import org.apache.kafka.common.security.authenticator.SaslClientAuthenticator;
+import org.apache.kafka.connect.json.JsonConverter;
+import org.apache.kafka.connect.source.SourceTask;
+import org.jboss.jandex.DotName;
import org.jboss.jandex.IndexView;
public class DebeziumSupportProcessor {
@BuildStep
- ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex) {
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(SaslClientAuthenticator.class.getName());
+ }
+
+ @BuildStep
+ void reflectiveClasses(CombinedIndexBuildItem combinedIndex, BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
IndexView index = combinedIndex.getIndex();
String[] dtos = index.getKnownClasses().stream().map(ci -> ci.name().toString())
.filter(n -> n.startsWith("org.apache.kafka.connect.json")
|| n.startsWith("io.debezium.engine.spi"))
.sorted()
.toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- return ReflectiveClassBuildItem.builder(dtos).fields().build();
- }
+ dtos = index.getAllKnownImplementations(DotName.createSimple(SnapshotLock.class.getName())).stream()
+ .map(ci -> ci.name().toString())
+ .sorted()
+ .toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- @BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { "org.apache.kafka.connect.storage.FileOffsetBackingStore",
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ "org.apache.kafka.connect.storage.FileOffsetBackingStore",
"org.apache.kafka.connect.storage.MemoryOffsetBackingStore",
+ "io.debezium.storage.kafka.history.KafkaSchemaHistory",
"io.debezium.relational.history.FileDatabaseHistory",
- "io.debezium.embedded.ConvertingEngineBuilderFactory" }).build();
- }
+ "io.debezium.embedded.ConvertingEngineBuilderFactory",
+ "io.debezium.processors.PostProcessorRegistry",
+ "io.debezium.pipeline.txmetadata.DefaultTransactionMetadataFactory",
+ "io.debezium.schema.SchemaTopicNamingStrategy",
+ "io.debezium.storage.file.history.FileSchemaHistory")
+ .build());
- @BuildStep
- void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
- indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
- indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ DebeziumEngine.BuilderFactory.class,
+ ConvertingAsyncEngineBuilderFactory.class,
+ SaslClientAuthenticator.class,
+ JsonConverter.class,
+ DefaultTransactionMetadataFactory.class,
+ SchemaTopicNamingStrategy.class,
+ BaseSourceTask.class,
+ SinkNotificationChannel.class,
+ LogNotificationChannel.class,
+ JmxNotificationChannel.class,
+ SnapshotLock.class,
+ NoLockingSupport.class,
+ AlwaysSnapshotter.class,
+ InitialSnapshotter.class,
+ InitialOnlySnapshotter.class,
+ NoDataSnapshotter.class,
+ RecoverySnapshotter.class,
+ WhenNeededSnapshotter.class,
+ NeverSnapshotter.class,
+ SchemaOnlySnapshotter.class,
+ SchemaOnlyRecoverySnapshotter.class,
+ ConfigurationBasedSnapshotter.class,
+ SourceSignalChannel.class,
+ KafkaSignalChannel.class,
+ FileSignalChannel.class,
+ JmxSignalChannel.class,
+ InProcessSignalChannel.class,
+ StandardActionProvider.class,
+ SourceTask.class)
+ .build());
}
- @BuildStep
- void registerServiceProviders(BuildProducer<NativeImageResourceBuildItem> nativeImage) {
- nativeImage.produce(
+ @BuildStep()
+ void registerNativeImageResources(BuildProducer<NativeImageResourceBuildItem> resources) {
+ resources.produce(new NativeImageResourceBuildItem(
+ "META-INF/services/io.debezium.embedded.async.ConvertingAsyncEngineBuilderFactory"));
+ resources.produce(
new NativeImageResourceBuildItem("META-INF/services/io.debezium.engine.DebeziumEngine$BuilderFactory"));
- }
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
Review Comment:
I've created an issue (with the follow up - because of the oracle - https://github.com/apache/camel-quarkus/issues/7638
and I added the instruction to refactor the service items during the follow-up works. Is it ok for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native (except Oracle) [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3191642657
> Just noticed there's changes to `ZipfileProcessor.java` in this PR. Are they still needed? If so, they should be in their own commit.
>
> Once that's solved, then I think this is ok to merge. Might be best to do that before the nightly job tries to auto update `camel-main` & create conflicts etc.
My bad, the zipfile change should be part of the https://github.com/apache/camel-quarkus/commit/41195dcb2bade7d1ac7724beabd8a7f1aebdb7de.
I'll fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native (except Oracle) [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3191725087
Zipfile bits are removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native (except Oracle) [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3191653423
It's probably even easier, the change is not required at all. All required is already in https://github.com/apache/camel-quarkus/commit/41195dcb2bade7d1ac7724beabd8a7f1aebdb7de
(this was just a dead end, which somehow ended in this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#discussion_r2276171520
##########
debezium-grouped-native.log:
##########
@@ -0,0 +1 @@
+[INFO] Scanning for projects...
Review Comment:
I guess we can remove this.
##########
extensions-support/debezium/deployment/src/main/java/org/apache/camel/quarkus/support/debezium/deployment/DebeziumSupportProcessor.java:
##########
@@ -24,45 +50,104 @@
import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
import org.apache.kafka.common.security.authenticator.SaslClientAuthenticator;
+import org.apache.kafka.connect.json.JsonConverter;
+import org.apache.kafka.connect.source.SourceTask;
+import org.jboss.jandex.DotName;
import org.jboss.jandex.IndexView;
public class DebeziumSupportProcessor {
@BuildStep
- ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex) {
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(SaslClientAuthenticator.class.getName());
+ }
+
+ @BuildStep
+ void reflectiveClasses(CombinedIndexBuildItem combinedIndex, BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
IndexView index = combinedIndex.getIndex();
String[] dtos = index.getKnownClasses().stream().map(ci -> ci.name().toString())
.filter(n -> n.startsWith("org.apache.kafka.connect.json")
|| n.startsWith("io.debezium.engine.spi"))
.sorted()
.toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- return ReflectiveClassBuildItem.builder(dtos).fields().build();
- }
+ dtos = index.getAllKnownImplementations(DotName.createSimple(SnapshotLock.class.getName())).stream()
+ .map(ci -> ci.name().toString())
+ .sorted()
+ .toArray(String[]::new);
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(dtos).fields().build());
- @BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { "org.apache.kafka.connect.storage.FileOffsetBackingStore",
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ "org.apache.kafka.connect.storage.FileOffsetBackingStore",
"org.apache.kafka.connect.storage.MemoryOffsetBackingStore",
+ "io.debezium.storage.kafka.history.KafkaSchemaHistory",
"io.debezium.relational.history.FileDatabaseHistory",
- "io.debezium.embedded.ConvertingEngineBuilderFactory" }).build();
- }
+ "io.debezium.embedded.ConvertingEngineBuilderFactory",
+ "io.debezium.processors.PostProcessorRegistry",
+ "io.debezium.pipeline.txmetadata.DefaultTransactionMetadataFactory",
+ "io.debezium.schema.SchemaTopicNamingStrategy",
+ "io.debezium.storage.file.history.FileSchemaHistory")
+ .build());
- @BuildStep
- void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
- indexDependency.produce(new IndexDependencyBuildItem("org.apache.kafka", "connect-json"));
- indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-api"));
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ DebeziumEngine.BuilderFactory.class,
+ ConvertingAsyncEngineBuilderFactory.class,
+ SaslClientAuthenticator.class,
+ JsonConverter.class,
+ DefaultTransactionMetadataFactory.class,
+ SchemaTopicNamingStrategy.class,
+ BaseSourceTask.class,
+ SinkNotificationChannel.class,
+ LogNotificationChannel.class,
+ JmxNotificationChannel.class,
+ SnapshotLock.class,
+ NoLockingSupport.class,
+ AlwaysSnapshotter.class,
+ InitialSnapshotter.class,
+ InitialOnlySnapshotter.class,
+ NoDataSnapshotter.class,
+ RecoverySnapshotter.class,
+ WhenNeededSnapshotter.class,
+ NeverSnapshotter.class,
+ SchemaOnlySnapshotter.class,
+ SchemaOnlyRecoverySnapshotter.class,
+ ConfigurationBasedSnapshotter.class,
+ SourceSignalChannel.class,
+ KafkaSignalChannel.class,
+ FileSignalChannel.class,
+ JmxSignalChannel.class,
+ InProcessSignalChannel.class,
+ StandardActionProvider.class,
+ SourceTask.class)
+ .build());
}
- @BuildStep
- void registerServiceProviders(BuildProducer<NativeImageResourceBuildItem> nativeImage) {
- nativeImage.produce(
+ @BuildStep()
+ void registerNativeImageResources(BuildProducer<NativeImageResourceBuildItem> resources) {
+ resources.produce(new NativeImageResourceBuildItem(
+ "META-INF/services/io.debezium.embedded.async.ConvertingAsyncEngineBuilderFactory"));
+ resources.produce(
new NativeImageResourceBuildItem("META-INF/services/io.debezium.engine.DebeziumEngine$BuilderFactory"));
- }
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
+ resources.produce(new NativeImageResourceBuildItem("META-INF/services/io.debezium.spi.snapshot.Snapshotter"));
Review Comment:
Seems we have `META-INF/services/io.debezium.spi.snapshot.Snapshotter` duplicated.
In general, we should perhaps use `ServiceProviderBuildItem` instead of `NativeImageResourceBuildItem`, passing in the Service class name from Class.getName(). That way you detect breakages if APIs change / get removed etc.
##########
extensions/debezium-mongodb/deployment/src/main/java/org/apache/camel/quarkus/component/debezium/mongodb/deployment/DebeziumMongodbProcessor.java:
##########
@@ -32,8 +37,18 @@ FeatureBuildItem feature() {
}
@BuildStep
- ReflectiveClassBuildItem reflectiveClasses() {
- return ReflectiveClassBuildItem.builder(new String[] { MongoDbConnector.class.getName(),
- MongoDbConnectorTask.class.getName() }).build();
+ void reflectiveClasses(BuildProducer<ReflectiveClassBuildItem> reflectiveClasses) {
+
+ reflectiveClasses.produce(ReflectiveClassBuildItem.builder(
+ MongoDbConnector.class,
+ MongoDbConnectorTask.class,
+ MongoDbSourceInfoStructMaker.class,
+ DefaultMongoDbAuthProvider.class,
+ SelectAllSnapshotQuery.class).build());
+ }
+
+ @BuildStep
+ void addDependencies(BuildProducer<IndexDependencyBuildItem> indexDependency) {
+ indexDependency.produce(new IndexDependencyBuildItem("io.debezium", "debezium-connector-mongodb"));
Review Comment:
Question: There is no Jandex usage in `DebeziumMongodbProcessor`, so where do we use these indexed classes. Is it in `DebeziumSupportProcessor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native (except Oracle) [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3191564189
Just noticed there's changes to `ZipfileProcessor.java` in this PR. Are they still needed? If so, they should be in their own commit.
Once that's solved, then I think this is ok to merge. Might be best to do that before the nightly job tries to auto update `camel-main` & create conflicts etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [camel-main] Fixed debezium native for Postgresql, Mongodb and Mysql [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #7634:
URL: https://github.com/apache/camel-quarkus/pull/7634#issuecomment-3190737826
> * the mssql test requires MySQL connector-j(see https://github.com/apache/camel-quarkus/blob/main/integration-test-groups/debezium/mssql/pom.xml#L51)
Oh, I messed up there π
. You can remove it from mssql where it should not be required. It's only for the MySQL bits.
All of the native support for it should come from `quarkus-jdbc-mysql`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org