You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Stephen Solka (JIRA)" <ji...@apache.org> on 2007/12/26 20:37:43 UTC
[jira] Created: (JSPWIKI-115) Change VariableManager.getValue to
use reflection instead of a series of if statements
Change VariableManager.getValue to use reflection instead of a series of if statements
--------------------------------------------------------------------------------------
Key: JSPWIKI-115
URL: https://issues.apache.org/jira/browse/JSPWIKI-115
Project: JSPWiki
Issue Type: Improvement
Components: Core & storage
Reporter: Stephen Solka
Priority: Minor
A fixme tag was on getValue about cleaning up how system variables were handled. Currently a series of if else blocks goes through and designates a response for specific variables names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-115) Change VariableManager.getValue to
use reflection instead of a series of if statements
Posted by "Stephen Solka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554460 ]
Stephen Solka commented on JSPWIKI-115:
---------------------------------------
I forgot to mention patch was created against HEAD checked out december 26th. I believe its called v2.6.1-cvs-1
> Change VariableManager.getValue to use reflection instead of a series of if statements
> --------------------------------------------------------------------------------------
>
> Key: JSPWIKI-115
> URL: https://issues.apache.org/jira/browse/JSPWIKI-115
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Reporter: Stephen Solka
> Priority: Minor
> Attachments: var_reflection.patch
>
>
> A fixme tag was on getValue about cleaning up how system variables were handled. Currently a series of if else blocks goes through and designates a response for specific variables names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-115) Change VariableManager.getValue to
use reflection instead of a series of if statements
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554468 ]
Janne Jalkanen commented on JSPWIKI-115:
----------------------------------------
Good idea, but I think it might be a better to stick to the regular getXXX() conventions of beans. They *will* make life easier in the future.
> Change VariableManager.getValue to use reflection instead of a series of if statements
> --------------------------------------------------------------------------------------
>
> Key: JSPWIKI-115
> URL: https://issues.apache.org/jira/browse/JSPWIKI-115
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Reporter: Stephen Solka
> Priority: Minor
> Attachments: var_reflection.patch
>
>
> A fixme tag was on getValue about cleaning up how system variables were handled. Currently a series of if else blocks goes through and designates a response for specific variables names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-115) Change VariableManager.getValue to
use reflection instead of a series of if statements
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen resolved JSPWIKI-115.
------------------------------------
Resolution: Fixed
Fixed in 2.7.0-svn-8
> Change VariableManager.getValue to use reflection instead of a series of if statements
> --------------------------------------------------------------------------------------
>
> Key: JSPWIKI-115
> URL: https://issues.apache.org/jira/browse/JSPWIKI-115
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Reporter: Stephen Solka
> Priority: Minor
> Fix For: 2.8
>
> Attachments: var_reflection.patch, var_reflection_wGets.patch
>
>
> A fixme tag was on getValue about cleaning up how system variables were handled. Currently a series of if else blocks goes through and designates a response for specific variables names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-115) Change VariableManager.getValue to
use reflection instead of a series of if statements
Posted by "Stephen Solka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554476 ]
Stephen Solka commented on JSPWIKI-115:
---------------------------------------
Since currently we lowercase varnames prior to processing do you think getvarname() would look odd? example getusername(). Normally with beans its getUsername(). Should I capitalize the first letter before obtaining the methods that way they stick to the bean standard or should I just change var_ to get?
> Change VariableManager.getValue to use reflection instead of a series of if statements
> --------------------------------------------------------------------------------------
>
> Key: JSPWIKI-115
> URL: https://issues.apache.org/jira/browse/JSPWIKI-115
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Reporter: Stephen Solka
> Priority: Minor
> Attachments: var_reflection.patch
>
>
> A fixme tag was on getValue about cleaning up how system variables were handled. Currently a series of if else blocks goes through and designates a response for specific variables names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-115) Change VariableManager.getValue to
use reflection instead of a series of if statements
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554540 ]
Janne Jalkanen commented on JSPWIKI-115:
----------------------------------------
Yup, capitalization sounds good. That's the Java standard :-)
> Change VariableManager.getValue to use reflection instead of a series of if statements
> --------------------------------------------------------------------------------------
>
> Key: JSPWIKI-115
> URL: https://issues.apache.org/jira/browse/JSPWIKI-115
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Reporter: Stephen Solka
> Priority: Minor
> Attachments: var_reflection.patch
>
>
> A fixme tag was on getValue about cleaning up how system variables were handled. Currently a series of if else blocks goes through and designates a response for specific variables names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.