You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by amansinha100 <gi...@git.apache.org> on 2015/10/27 17:31:48 UTC

[GitHub] drill pull request: DRILL-3937: Handle the case where min/max colu...

GitHub user amansinha100 opened a pull request:

    https://github.com/apache/drill/pull/220

    DRILL-3937: Handle the case where min/max columns in metadata cache f…

    …ile are Maps.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amansinha100/incubator-drill DRILL-3937

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
    
----
commit d331330efd27dbb8922024c4a18c11e76a00016b
Author: Aman Sinha <as...@maprtech.com>
Date:   2015-10-26T07:02:11Z

    DRILL-3937: Handle the case where min/max columns in metadata cache file are Maps.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3937: Handle the case where min/max colu...

Posted by mehant <gi...@git.apache.org>.
Github user mehant commented on the pull request:

    https://github.com/apache/drill/pull/220#issuecomment-152327591
  
    +1. 
    Except for the minor comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3937: Handle the case where min/max colu...

Posted by mehant <gi...@git.apache.org>.
Github user mehant commented on a diff in the pull request:

    https://github.com/apache/drill/pull/220#discussion_r43444174
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java ---
    @@ -494,5 +497,48 @@ public ColumnMetadata(SchemaPath name, PrimitiveTypeName primitiveType, Original
           this.min = min;
           this.nulls = nulls;
         }
    +
    +    @JsonProperty(value = "min")
    +    public Object getMin() {
    +      if (primitiveType == PrimitiveTypeName.BINARY) {
    +        if (originalType == OriginalType.UTF8) {
    --- End diff --
    
    Had an offline discussion with Aman, we can remove this check and serialize everything using getBytes()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3937: Handle the case where min/max colu...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---