You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by DIPAYAN BHOWMICK <di...@gmail.com> on 2017/04/12 11:31:28 UTC

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review171710
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> -----------------------------------------------------------
> 
> (Updated April 5, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20334
>     https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> capacity field in yarn queue manager should allow entering decimal numbers upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>


Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

Posted by Anita Jebaraj <aj...@us.ibm.com>.

> On April 12, 2017, 11:31 a.m., DIPAYAN BHOWMICK wrote:
> > Ship It!

Thank you for reviewing, can you please help in pushing the changes?


- Anita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review171710
-----------------------------------------------------------


On April 5, 2017, 9:43 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> -----------------------------------------------------------
> 
> (Updated April 5, 2017, 9:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, belliraj hb, Di Li, DIPAYAN BHOWMICK, Jaimin Jetly, Richard Zang, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20334
>     https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> capacity field in yarn queue manager should allow entering decimal numbers upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>