You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dinesh Bhat (Code Review)" <ge...@cloudera.org> on 2016/08/12 08:41:13 UTC

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata 

Hello Dan Burkert, Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3955

to review the following change.

Change subject:     KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata
......................................................................

KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

    The test intends to corrupt the metadata of one of the tserver tablets.
    While the cluster is in the process of resurrecting the failed tserver,
    the Partition and PartitionSchema on that tserver is accessed using
    TabletPeer in an unguarded manner via ListTablets RPCs.

    The proposed fix here keeps the Partition and PartitionSchema immutable
    once after it is loaded during replica bootstrap. These fields are never
    overwritten again during Tablet Copy or any other workflow.
    Also a unit test is added to exercise this data race window. i.e,
    the unit test aims to issue ListTablets RPCs during a follower's
    tablet copy stage and provides an optimistic coverage for the fix.

    Testing: Passed about 2000 iteration of the failing test
    raft_consensus-itest.TestCorruptReplicaMetadata

    Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019

Change-Id: I0a7a62b7c5aa62e9888b4b454790861df9fe2ad5
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/tablet/tablet_metadata.cc
4 files changed, 136 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3955/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a7a62b7c5aa62e9888b4b454790861df9fe2ad5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has abandoned this change.

Change subject:     KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata
......................................................................


Abandoned

abandoning due to duplicate links. original review is under http://gerrit.cloudera.org:8080/3823

-- 
To view, visit http://gerrit.cloudera.org:8080/3955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0a7a62b7c5aa62e9888b4b454790861df9fe2ad5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject:     KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2834/

-- 
To view, visit http://gerrit.cloudera.org:8080/3955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7a62b7c5aa62e9888b4b454790861df9fe2ad5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No