You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/03/31 00:34:58 UTC
[kudu-CR] Change row projector schema equality check to use physical column type
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2672
to review the following change.
Change subject: Change row projector schema equality check to use physical column type
......................................................................
Change row projector schema equality check to use physical column type
Previously the row projector was using the physical type to build codegen cache
keys, but using the type when comparing projections, resulting in spurious debug
check failures.
Change-Id: I5e9a8d9c003be3942d3ce6f93d880adb45d8ded6
---
M src/kudu/codegen/row_projector.cc
M src/kudu/common/schema.h
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/2672/1
--
To view, visit http://gerrit.cloudera.org:8080/2672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e9a8d9c003be3942d3ce6f93d880adb45d8ded6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>