You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/14 18:20:12 UTC

[GitHub] [iceberg] szehon-ho commented on a change in pull request #3872: Spark : Support parallelism in RemoveOrphanFiles

szehon-ho commented on a change in pull request #3872:
URL: https://github.com/apache/iceberg/pull/3872#discussion_r785059817



##########
File path: spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java
##########
@@ -86,6 +87,8 @@
     }
   }, DataTypes.StringType);
 
+  private static final ExecutorService DEFAULT_DELETE_EXECUTOR_SERVICE = null;

Review comment:
       Not sure I see a huge point to this variable (feel like a comment could have sufficed), but I guess it's there in the other version, so no matter :)
   
   I guess the explicit assumption is that Tasks execute without a service, executes the task on a single thread.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org