[GitHub] [hudi] minihippo commented on a change in pull request #3173: [HUDI-1951] Add bucket hash index, compatible with the hive bucket

[GitBox <gi...@apache.org>]

minihippo commented on a change in pull request #3173:
URL: https://github.com/apache/hudi/pull/3173#discussion_r685122711



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/BaseKeyGenerator.java
##########
@@ -71,11 +84,25 @@ public final HoodieKey getKey(GenericRecord record) {
     }).collect(Collectors.toList());
   }
 
+  public List<String> getIndexKeyFields() {
+    return indexKeyFields;
+  }
+
   public List<String> getRecordKeyFields() {
     return recordKeyFields;
   }
 
   public List<String> getPartitionPathFields() {
     return partitionPathFields;
   }
+
+  protected void validateIndexKeyField() {
+    if (indexKeyFields.size() != 0) {

Review comment:
       Check the bucket index key field config when building the HoodieIndexConfig and add the relevant uts in `TestHoodieIndex`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org