[jira] [Commented] (CAMEL-9862) Potential NPE in UndertowComponent.unregisterConsumer

["Claus Ibsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238784#comment-15238784 ] 

Claus Ibsen commented on CAMEL-9862:
------------------------------------

Can you do a PR

> Potential NPE in UndertowComponent.unregisterConsumer
> -----------------------------------------------------
>
>                 Key: CAMEL-9862
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9862
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-undertow
>    Affects Versions: 2.16.3, 2.17.0
>            Reporter: James Netherton
>            Priority: Minor
>             Fix For: 2.16.4, 2.17.1, 2.18.0
>
>
> There's a potential NPE in the UndertowComponent class when Undertow consumers are stopped. Here's a snippet from the unregisterConsumer method:
> {code}
>     public void unregisterConsumer(UndertowConsumer consumer) {
>         int port = consumer.getEndpoint().getHttpURI().getPort();
>         if (serversRegistry.containsKey(port)) {
>             serversRegistry.get(port).unregisterConsumer(consumer);
>         }
>         if (serversRegistry.get(port).isEmpty()) {
>           // stuff happens here
>         }
>     }
> {code}
> If serversRegistry.containsKey returns false for the given port, then we should not be proceeding to call methods like isEmpty afterwards.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)