You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/05 03:33:38 UTC

[GitHub] [flink] godfreyhe opened a new pull request #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

godfreyhe opened a new pull request #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment
URL: https://github.com/apache/flink/pull/8619
 
 
   
   ## What is the purpose of the change
   
   *remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment*
   
   
   ## Brief change log
   
     - *remove getVolcanoPlanner method from FlinkOptimizeContext.
   VolcanoPlanner limits that the planer a RelNode tree belongs to and the VolcanoPlanner used to optimize the RelNode tree should be same instance. (see: VolcanoPlanner#registerImpl)
   so, we can use planner instance in RelNode's cluster directly instead of getVolcanoPlanner from FlinkOptimizeContext.*
     - * RelNodeBlock does not depend on TableEnvironment*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services