You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/09/25 08:40:57 UTC

[PR] Add IT for MRESOURCES-301 - binary JAR files must not be filtered by default [maven-resources-plugin]

gnodet opened a new pull request, #529:
URL: https://github.com/apache/maven-resources-plugin/pull/529

   ## Summary
   
   Regression test for [MRESOURCES-301](https://issues.apache.org/jira/browse/MRESOURCES-301) — `nonFilteredFileExtension` not taken into account.
   
   ## What this IT does
   
   Places a binary (non-UTF-8) `.jar` file in a resource directory configured with `<filtering>true</filtering>`, **without any `nonFilteredFileExtensions` configuration**, then verifies:
   
   1. The build does **not** fail with `MalformedInputException`
   2. The output `binary.jar` is byte-for-byte identical to the source
   
   ## Companion fix
   
   The actual fix lives in **maven-filtering PR #405** which expands the default non-filtered extension list to include `jar`, `zip`, `war` and many other common binary formats. This IT is the integration-level regression guard for that fix.
   
   The IT currently **fails** on the `master` SNAPSHOT (confirms the bug is present before the fix) and will pass once the plugin picks up the updated maven-filtering version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add IT for MRESOURCES-301 - binary JAR files must not be filtered by default [maven-resources-plugin]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #529:
URL: https://github.com/apache/maven-resources-plugin/pull/529


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add IT for MRESOURCES-301 - binary JAR files must not be filtered by default [maven-resources-plugin]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #529:
URL: https://github.com/apache/maven-resources-plugin/pull/529#issuecomment-5876242557

   Hi @cstamas, @desruisseaux, @slachiewicz, @slawekjaranowski, @rmanibuceau, @bukama — this PR is targeted for the **4.0.0-beta-2** milestone and hasn't received any reviews yet. Would any of you have time to take a look? 🙏
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org