You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/03 12:28:21 UTC
[GitHub] [flink] NicoK opened a new pull request, #21230: [FLINK-15633][build] Fix building Javadocs on JDK 11
NicoK opened a new pull request, #21230:
URL: https://github.com/apache/flink/pull/21230
## What is the purpose of the change
Javadocs won't build when building for Java 11, e.g. like this:
```
./mvnw clean package javadoc:jar -Pjava11 -Pjava11-target -pl flink-dist -am -Drat.skip=true -Dcheckstyle.skip=true -Dspotless.apply.skip -DskipTests
```
## Brief change log
- add missing `add-exports` for `java.rmi/sun.rmi.registry` to make it work
- use `<additionalJOptions combine.children="append">` to make sure parent options are not overridden
## Verifying this change
Verified with the build command from above
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NicoK commented on pull request #21230: [FLINK-15633][build] Fix building Javadocs on JDK 11
Posted by GitBox <gi...@apache.org>.
NicoK commented on PR #21230:
URL: https://github.com/apache/flink/pull/21230#issuecomment-1303158024
FYI: test failure is due to FLINK-25306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NicoK merged pull request #21230: [FLINK-15633][build] Fix building Javadocs on JDK 11
Posted by GitBox <gi...@apache.org>.
NicoK merged PR #21230:
URL: https://github.com/apache/flink/pull/21230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NicoK commented on a diff in pull request #21230: [FLINK-15633][build] Fix building Javadocs on JDK 11
Posted by GitBox <gi...@apache.org>.
NicoK commented on code in PR #21230:
URL: https://github.com/apache/flink/pull/21230#discussion_r1012972117
##########
pom.xml:
##########
@@ -990,8 +990,9 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
- <additionalJOptions>
+ <additionalJOptions combine.children="append">
Review Comment:
Alright - saw it bus wasn't sure that it's enough to have it only once...I'll adapt the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21230: [FLINK-15633][build] Fix building Javadocs on JDK 11
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21230:
URL: https://github.com/apache/flink/pull/21230#issuecomment-1302036361
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "add27e579c10ab8473a0c716ea10568766fb0197",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "add27e579c10ab8473a0c716ea10568766fb0197",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* add27e579c10ab8473a0c716ea10568766fb0197 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21230: [FLINK-15633][build] Fix building Javadocs on JDK 11
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21230:
URL: https://github.com/apache/flink/pull/21230#discussion_r1012887371
##########
pom.xml:
##########
@@ -990,8 +990,9 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
- <additionalJOptions>
+ <additionalJOptions combine.children="append">
Review Comment:
this isn't necessary; it's already set up in the main javadoc-plugin config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org