[jira] [Commented] (IMPALA-8307) ntp-wait --help does not always return 0

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802961#comment-16802961 ] 

ASF subversion and git services commented on IMPALA-8307:
---------------------------------------------------------

Commit 7cdeab7f75bfcf98c15f8554586aa621cbe9b631 in impala's branch refs/heads/master from Hector Acosta
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7cdeab7 ]

IMPALA-8307 Use test -x to check for ntp-wait

Running ntp-wait --help can return 0 or 1 depending on the
output of ntpq. For example:

$ sudo ntp-wait --help 2> /dev/null; echo $?
0
$ sudo killall ntpd
$ sudo ntp-wait --help 2> /dev/null; echo $?
1

This commit instead tests whether ntp-wait exists and is executable to
determine if it's installed.

Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c
Reviewed-on: http://gerrit.cloudera.org:8080/12726
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> ntp-wait --help does not always return 0
> ----------------------------------------
>
>                 Key: IMPALA-8307
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8307
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Hector Acosta
>            Priority: Major
>
> testdata/cluster/admin uses `ntp-wait --help` to determine if ntp-wait is installed or not. The test is not reliable since ntp-wait --help can both return 1 or 0 depending on the output of  
> {code:java}
> /usr/sbin/ntpq -c "rv 0"{code}
> (which is what ntp-wait does under the hood).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org