[jira] [Updated] (TINKERPOP-1106) Errors on commit in Gremlin Server don't register as exception on driver

["stephen mallette (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TINKERPOP-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stephen mallette updated TINKERPOP-1106:
----------------------------------------
    Description: 
Because the last message in a result is sent before commit as the terminating message, a failure on {{commit()}} will send another message, but the driver won't be looking for it and it will not register as an exception on that request.

Seems like the solution would be to save the last message until after commit, and if the commit fails, you would send the error back otherwise send the last message.  In this way the protocol doesn't have to change.

Also need to determine if exceptions prevent additional iteration of results back to the client as discussed here:

https://groups.google.com/d/msg/gremlin-users/H5IlmZ4Zgyc/ENfScPisCgAJ

  was:
Because the last message in a result is sent before commit as the terminating message, a failure on {{commit()}} will send another message, but the driver won't be looking for it and it will not register as an exception on that request.

Seems like the solution would be to save the last message until after commit, and if the commit fails, you would send the error back otherwise send the last message.  In this way the protocol doesn't have to change.


> Errors on commit in Gremlin Server don't register as exception on driver
> ------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1106
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1106
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: driver
>    Affects Versions: 3.1.1-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Critical
>             Fix For: 3.1.2-incubating
>
>
> Because the last message in a result is sent before commit as the terminating message, a failure on {{commit()}} will send another message, but the driver won't be looking for it and it will not register as an exception on that request.
> Seems like the solution would be to save the last message until after commit, and if the commit fails, you would send the error back otherwise send the last message.  In this way the protocol doesn't have to change.
> Also need to determine if exceptions prevent additional iteration of results back to the client as discussed here:
> https://groups.google.com/d/msg/gremlin-users/H5IlmZ4Zgyc/ENfScPisCgAJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)