You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2015/02/03 13:28:27 UTC

Re: Review Request 29847: CLOUDSTACK-8153: Adding global setting value check for few test cases in test_custom_hostname.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29847/#review70737
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Jan. 22, 2015, 10:27 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29847/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 10:27 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8153
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8153
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test cases need vm.instancename.flag set to be true. Added check for that.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_custom_hostname.py fcd497e 
> 
> Diff: https://reviews.apache.org/r/29847/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 29847: CLOUDSTACK-8153: Adding global setting value check for few test cases in test_custom_hostname.py

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.

> On Feb. 3, 2015, 12:28 p.m., SrikanteswaraRao Talluri wrote:
> > Ship It!

dbe9d93ec61948097c4c076bbeb13d30a8b5c44a master


- SrikanteswaraRao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29847/#review70737
-----------------------------------------------------------


On Jan. 22, 2015, 10:27 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29847/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 10:27 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8153
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8153
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test cases need vm.instancename.flag set to be true. Added check for that.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_custom_hostname.py fcd497e 
> 
> Diff: https://reviews.apache.org/r/29847/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>