You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by gk...@apache.org on 2007/09/19 13:11:48 UTC

svn commit: r577245 - /cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java

Author: gkossakowski
Date: Wed Sep 19 04:11:47 2007
New Revision: 577245

URL: http://svn.apache.org/viewvc?rev=577245&view=rev
Log:
COCOON-2134: Implemented Disposable interface in StringTemplateParserVariableResolver.

Modified:
    cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java

Modified: cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java?rev=577245&r1=577244&r2=577245&view=diff
==============================================================================
--- cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java (original)
+++ cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java Wed Sep 19 04:11:47 2007
@@ -18,6 +18,7 @@
 
 import java.util.Map;
 
+import org.apache.avalon.framework.activity.Disposable;
 import org.apache.cocoon.components.treeprocessor.InvokeContext;
 import org.apache.cocoon.el.objectmodel.ObjectModel;
 import org.apache.cocoon.el.parsing.StringTemplateParser;
@@ -29,7 +30,7 @@
  *
  * @version $Id$
  */
-public final class StringTemplateParserVariableResolver extends VariableResolver {
+public final class StringTemplateParserVariableResolver extends VariableResolver implements Disposable {
     
     public final static String ROLE = StringTemplateParserVariableResolver.class.getName();
     
@@ -79,6 +80,10 @@
         } catch (Exception e) {
             throw new PatternException(e);
         }
+    }
+
+    public void dispose() {
+        //nothing to do
     }
 
 }

Re: svn commit: r577245 - /cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java

Posted by Grzegorz Kossakowski <gk...@apache.org>.
Joerg Heinicke pisze:
> On 19.09.2007 7:11 Uhr, gkossakowski@apache.org wrote:
> 
>> URL: http://svn.apache.org/viewvc?rev=577245&view=rev
>> Log:
>> COCOON-2134: Implemented Disposable interface in
>> StringTemplateParserVariableResolver.
> 
> I wonder why a Spring-configured bean has to implement Avalon interfaces
> especially since it is an empty implementation anyway. Wouldn't it be
> better to make a instanceof check instead of enforcing the
> implementation? Otherwise I don't see how we can get rid of Avalon. We
> need such a migration path, don't we?

Thanks for reviewing, you have a good point.

The solution I came with was the simplest and most reliable I could think of. After taking another
look at the code from o.a.c.components.treeprocessor.variables.VariableResolverFactory class I start
to think that we could remove custom managment of Disposable components completely but I will be
better to have detailed look into that code later on.

-- 
Grzegorz Kossakowski
Committer and PMC Member of Apache Cocoon
http://reflectingonthevicissitudes.wordpress.com/

Re: svn commit: r577245 - /cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/treeprocessor/variables/StringTemplateParserVariableResolver.java

Posted by Joerg Heinicke <jo...@gmx.de>.
On 19.09.2007 7:11 Uhr, gkossakowski@apache.org wrote:

> URL: http://svn.apache.org/viewvc?rev=577245&view=rev
> Log:
> COCOON-2134: Implemented Disposable interface in StringTemplateParserVariableResolver.

I wonder why a Spring-configured bean has to implement Avalon interfaces 
especially since it is an empty implementation anyway. Wouldn't it be 
better to make a instanceof check instead of enforcing the 
implementation? Otherwise I don't see how we can get rid of Avalon. We 
need such a migration path, don't we?

Joerg