You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2019/06/25 23:14:44 UTC
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13731
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Fix incorrect timestamp units in the logs
EventSequence.markEvent() returns ns, so the existing conversion
is incorrect.
Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
---
M fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/13731/1
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Fix incorrect timestamp units in the logs
EventSequence.markEvent() returns ns, so the existing conversion
is incorrect.
Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Reviewed-on: http://gerrit.cloudera.org:8080/13731
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 4
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4547/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 03:41:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4547/
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 09:21:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has removed a vote on this change.
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 03:41:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3747/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 00:02:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 23:02:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 2: Code-Review+2
> Patch Set 2: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4547/
Unrelated flaky tests. Re-running the merge.
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:25:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4552/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:26:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:26:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix incorrect timestamp units in the logs
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13731 )
Change subject: Fix incorrect timestamp units in the logs
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/13731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I132a007404dcf5291e70f2642ed3e9f995d694b1
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 03:40:32 +0000
Gerrit-HasComments: No