You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "zabetak (via GitHub)" <gi...@apache.org> on 2023/06/17 16:01:05 UTC
[GitHub] [hive] zabetak opened a new pull request, #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
zabetak opened a new pull request, #4430:
URL: https://github.com/apache/hive/pull/4430
### What changes were proposed in this pull request?
1. Pick-up user defined security.protocol to obtain the delegation token.
2. Propagate all necessary SSL properties to Kafka client retrieving the token.
3. Add KafkaUtils#securityProtocol utility function for fetching the protocol from properties and refactor
`KafkaDagCredentialSupplier#isTokenRequired` to use it.
4. Accept fetching Kafka stores from any location; the main motivation is to accept paths to the local file system to facilitate testing without having to setup a DFS cluster. Anyways if the copy fails a proper IO exception will be raised with more details about what went wrong.
5. Adapt exception in KafkaUtilsTest based on changes in store fetching
6. Create and configure a SAML_SSL enabled listener in KafkaBrokerResource to allow tests with SSL.
### Why are the changes needed?
The Kafka client that is used to obtain the token from the Kafka broker ignores the user defined `security.protocol` defined in the table properties (and pretty much every SSL configuration) thus the connection between the two cannot be established and an exception is raised. In order to avoid the problem, all the user-defined SSL properties must be propagated to the Kafka client retrieving the token.
### Does this PR introduce _any_ user-facing change?
No
### Is the change a dependency upgrade?
No
### How was this patch tested?
New + existing tests of the Kafka storage handler
`cd kafka-handler/ && mvn test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jfsii commented on pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "jfsii (via GitHub)" <gi...@apache.org>.
jfsii commented on PR #4430:
URL: https://github.com/apache/hive/pull/4430#issuecomment-1599171815
I put 1 nitty nit, otherwise this patch does make the code better than it was. Code dedup, new tests, and fixing an issue, nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238647550
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -91,17 +89,13 @@ public Text getTokenAlias() {
*/
private boolean isTokenRequired(TableDesc tableDesc) {
String kafkaBrokers = (String) tableDesc.getProperties().get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
- String consumerSecurityProtocol = (String) tableDesc.getProperties().get(
- CONSUMER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- String producerSecurityProtocol = (String) tableDesc.getProperties().get(
- PRODUCER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- return kafkaBrokers != null && !kafkaBrokers.isEmpty()
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(consumerSecurityProtocol)
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(producerSecurityProtocol);
+ SecurityProtocol protocol = KafkaUtils.securityProtocol(tableDesc.getProperties());
+ return kafkaBrokers != null && !kafkaBrokers.isEmpty() && SecurityProtocol.PLAINTEXT != protocol;
}
private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc tableDesc) {
- String kafkaBrokers = (String) tableDesc.getProperties().get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
+ Properties tableProperties = tableDesc.getProperties();
+ String kafkaBrokers = (String) tableProperties.get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
Review Comment:
Fixed in https://github.com/apache/hive/pull/4430/commits/45dae3d856028593bab73a0b1810952309450758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jfsii commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "jfsii (via GitHub)" <gi...@apache.org>.
jfsii commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1235548429
##########
kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplierTest.java:
##########
@@ -27,17 +27,35 @@
import org.apache.hadoop.io.Text;
import org.apache.hadoop.minikdc.MiniKdc;
import org.apache.hadoop.security.token.Token;
+import org.apache.kafka.common.config.SslConfigs;
+import org.apache.kafka.common.security.auth.SecurityProtocol;
+import com.google.common.collect.ImmutableMap;
+
Review Comment:
nit: Are these out of order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4430:
URL: https://github.com/apache/hive/pull/4430#issuecomment-1596939034
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4430)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4430&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4430&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238325450
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java:
##########
@@ -397,4 +421,31 @@ static void addKerberosJaasConf(Configuration configuration, Properties props) {
}
log.info("Kafka client running with following JAAS = [{}]", jaasConf);
}
+
+ /**
+ * Returns the security protocol if one is defined in the properties and null otherwise.
+ * <p>The following properties are examined to determine the protocol:</p>
+ * <ol>
+ * <li>security.protocol</li>
+ * <li>kafka.consumer.security.protocol</li>
+ * <li>kafka.producer.security.protocol</li>
+ * </ol>
+ * <p>and the first non null/not empty is returned.</p>
+ * <p>Defining multiple security protocols at the same time is invalid but this method is lenient and tries to pick
+ * the most reasonable option.</p>
+ * @param props the properties from which to obtain the protocol.
+ * @return the security protocol if one is defined in the properties and null otherwise.
+ */
+ static SecurityProtocol securityProtocol(Properties props) {
Review Comment:
Adding `extract` will make the method name longer and more verbose.
```java
if (securityProtocol(props) == SAML_SSL)
// vs
if (extractSecurityProtocol(props) == SAML_SSL)
```
I find the shorter variant more readable and equally expressive so I would be inclined to keep it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #4430:
URL: https://github.com/apache/hive/pull/4430#issuecomment-1602929711
Thanx Stamatis, good from my side, have already approved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] akshat0395 commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "akshat0395 (via GitHub)" <gi...@apache.org>.
akshat0395 commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238477531
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java:
##########
@@ -397,4 +421,31 @@ static void addKerberosJaasConf(Configuration configuration, Properties props) {
}
log.info("Kafka client running with following JAAS = [{}]", jaasConf);
}
+
+ /**
+ * Returns the security protocol if one is defined in the properties and null otherwise.
+ * <p>The following properties are examined to determine the protocol:</p>
+ * <ol>
+ * <li>security.protocol</li>
+ * <li>kafka.consumer.security.protocol</li>
+ * <li>kafka.producer.security.protocol</li>
+ * </ol>
+ * <p>and the first non null/not empty is returned.</p>
+ * <p>Defining multiple security protocols at the same time is invalid but this method is lenient and tries to pick
+ * the most reasonable option.</p>
+ * @param props the properties from which to obtain the protocol.
+ * @return the security protocol if one is defined in the properties and null otherwise.
+ */
+ static SecurityProtocol securityProtocol(Properties props) {
Review Comment:
I dont have any strong opinion on this, I generally like to start methods with a verb thats all. We can move ahead with this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kokila-19 commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "kokila-19 (via GitHub)" <gi...@apache.org>.
kokila-19 commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1236475893
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -123,6 +122,9 @@ private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
config.put(SaslConfigs.SASL_JAAS_CONFIG, jaasConfig);
LOG.debug("Jaas config for requesting kafka credentials: {}", jaasConfig);
+ Configuration copy = new Configuration(conf);
Review Comment:
This variable name could be changed. Copy is too generic, ex: config, copyconfig or tableconfig.
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -114,7 +108,12 @@ private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
Properties config = new Properties();
Review Comment:
In reference to refactoring variable name of copy in line no. 125 ., I think this name can be changed to **props or properties**. Improves code readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak closed pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
URL: https://github.com/apache/hive/pull/4430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238667927
##########
kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplierTest.java:
##########
@@ -27,17 +27,35 @@
import org.apache.hadoop.io.Text;
import org.apache.hadoop.minikdc.MiniKdc;
import org.apache.hadoop.security.token.Token;
+import org.apache.kafka.common.config.SslConfigs;
+import org.apache.kafka.common.security.auth.SecurityProtocol;
+import com.google.common.collect.ImmutableMap;
+
Review Comment:
Fixed in https://github.com/apache/hive/pull/4430/commits/c3b74d7254d28d8c75f811bbdbb94f11b40e4e6b.
Interestingly, we have no policy, checks, whatsoever on what should be the order of imports in Hive so we end-up with a mixed style with a bit of everything :)
It appears that I was using the import style from another Apache project; now I simply switched to IntelliJ's default cause it matched better the current style in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238578830
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -91,17 +89,13 @@ public Text getTokenAlias() {
*/
private boolean isTokenRequired(TableDesc tableDesc) {
String kafkaBrokers = (String) tableDesc.getProperties().get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
- String consumerSecurityProtocol = (String) tableDesc.getProperties().get(
- CONSUMER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- String producerSecurityProtocol = (String) tableDesc.getProperties().get(
- PRODUCER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- return kafkaBrokers != null && !kafkaBrokers.isEmpty()
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(consumerSecurityProtocol)
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(producerSecurityProtocol);
+ SecurityProtocol protocol = KafkaUtils.securityProtocol(tableDesc.getProperties());
+ return kafkaBrokers != null && !kafkaBrokers.isEmpty() && SecurityProtocol.PLAINTEXT != protocol;
Review Comment:
Can we use ```StringUtils.isEmpty()```
something like
```
!StringUtils.isEmpty(kafkaBrokers) && SecurityProtocol.PLAINTEXT != protocol;
```
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -91,17 +89,13 @@ public Text getTokenAlias() {
*/
private boolean isTokenRequired(TableDesc tableDesc) {
String kafkaBrokers = (String) tableDesc.getProperties().get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
- String consumerSecurityProtocol = (String) tableDesc.getProperties().get(
- CONSUMER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- String producerSecurityProtocol = (String) tableDesc.getProperties().get(
- PRODUCER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- return kafkaBrokers != null && !kafkaBrokers.isEmpty()
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(consumerSecurityProtocol)
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(producerSecurityProtocol);
+ SecurityProtocol protocol = KafkaUtils.securityProtocol(tableDesc.getProperties());
+ return kafkaBrokers != null && !kafkaBrokers.isEmpty() && SecurityProtocol.PLAINTEXT != protocol;
}
private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc tableDesc) {
- String kafkaBrokers = (String) tableDesc.getProperties().get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
+ Properties tableProperties = tableDesc.getProperties();
+ String kafkaBrokers = (String) tableProperties.get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
Review Comment:
can we do
```
String kafkaBrokers = tableProperties.getProperty(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
```
rather than casting to (String) here
##########
kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplierTest.java:
##########
@@ -75,13 +93,39 @@ public static void stopCluster() {
}
@Test
- public void testObtainTokenNotNull() {
+ public void testObtainTokenFromSamlPlainTextListenerNotNull() {
+ Properties props = new Properties();
+ props.setProperty("kafka.bootstrap.servers", KafkaBrokerResource.BROKER_SASL_PORT);
+ checkObtainToken(props);
+ }
+
+ @Test
+ public void testObtainTokenFromSamlSslListenerNotNull()
+ throws IOException, URISyntaxException, KeyStoreException, CertificateException, NoSuchAlgorithmException {
+ Properties props = new Properties();
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_BOOTSTRAP_SERVERS.getName(),
+ KafkaBrokerResource.BROKER_SASL_SSL_PORT);
+ // Should the SSL properties be divided between producer/consumer? Probably not!
+ props.setProperty(SECURITY_PROTOCOL_CONFIG, SecurityProtocol.SASL_SSL.name);
+ props.setProperty(SslConfigs.SSL_ENDPOINT_IDENTIFICATION_ALGORITHM_CONFIG, "");
+ String pwdAlias = "HereIsAnAliasForTheKeyWhichHoldsTheTrustorePassword";
+ URI storeURI = createCredentialStore(ImmutableMap.of(pwdAlias, KAFKA_BROKER_RESOURCE.getTruststorePwd()));
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_CREDENTIAL_KEYSTORE.getName(), storeURI.toString());
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_TRUSTSTORE_PASSWORD.getName(), pwdAlias);
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_KEYSTORE_PASSWORD.getName(), "");
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_KEY_PASSWORD.getName(), "");
+ String location = KAFKA_BROKER_RESOURCE.getTruststorePath().toUri().toString();
Review Comment:
``getTruststorePath()`` by code can return ``null`` as well, so, if does we would fail with NPE here
```
Path getTruststorePath() {
return truststoreFile != null ? truststoreFile.toPath() : null;
}
```
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -114,7 +108,12 @@ private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
Properties config = new Properties();
config.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG, kafkaBrokers);
- config.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, SecurityProtocol.SASL_PLAINTEXT.name);
+ SecurityProtocol protocol = KafkaUtils.securityProtocol(tableProperties);
+ if (protocol == null) {
+ protocol = SecurityProtocol.SASL_PLAINTEXT;
+ LOG.warn("Kafka security.protocol is undefined in table properties. Using default {}", protocol.name);
Review Comment:
nit:
you could have saved this if check, if in ``KafkaUtils.securityProtocol`` rather than returning ``null``, return the default & put a log before that
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java:
##########
@@ -397,4 +421,31 @@ static void addKerberosJaasConf(Configuration configuration, Properties props) {
}
log.info("Kafka client running with following JAAS = [{}]", jaasConf);
}
+
+ /**
+ * Returns the security protocol if one is defined in the properties and null otherwise.
+ * <p>The following properties are examined to determine the protocol:</p>
+ * <ol>
+ * <li>security.protocol</li>
+ * <li>kafka.consumer.security.protocol</li>
+ * <li>kafka.producer.security.protocol</li>
+ * </ol>
+ * <p>and the first non null/not empty is returned.</p>
+ * <p>Defining multiple security protocols at the same time is invalid but this method is lenient and tries to pick
+ * the most reasonable option.</p>
+ * @param props the properties from which to obtain the protocol.
+ * @return the security protocol if one is defined in the properties and null otherwise.
+ */
+ static SecurityProtocol securityProtocol(Properties props) {
+ List<String> securityProtocolConfigs = Arrays.asList(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG,
+ CONSUMER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG,
+ PRODUCER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
Review Comment:
Why you need ``Arrays.asList``, can't we directly have an array?
```
String[] securityProtocolConfigs = new String[] {CommonClientConfigs.SECURITY_PROTOCOL_CONFIG,
CONSUMER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG,
PRODUCER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] akshat0395 commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "akshat0395 (via GitHub)" <gi...@apache.org>.
akshat0395 commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1236651112
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java:
##########
@@ -397,4 +421,31 @@ static void addKerberosJaasConf(Configuration configuration, Properties props) {
}
log.info("Kafka client running with following JAAS = [{}]", jaasConf);
}
+
+ /**
+ * Returns the security protocol if one is defined in the properties and null otherwise.
+ * <p>The following properties are examined to determine the protocol:</p>
+ * <ol>
+ * <li>security.protocol</li>
+ * <li>kafka.consumer.security.protocol</li>
+ * <li>kafka.producer.security.protocol</li>
+ * </ol>
+ * <p>and the first non null/not empty is returned.</p>
+ * <p>Defining multiple security protocols at the same time is invalid but this method is lenient and tries to pick
+ * the most reasonable option.</p>
+ * @param props the properties from which to obtain the protocol.
+ * @return the security protocol if one is defined in the properties and null otherwise.
+ */
+ static SecurityProtocol securityProtocol(Properties props) {
Review Comment:
nit: can we rename this to extractSecurityProtocol?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4430:
URL: https://github.com/apache/hive/pull/4430#issuecomment-1595809056
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4430)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4430&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4430&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238269188
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -114,7 +108,12 @@ private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
Properties config = new Properties();
Review Comment:
In general, I like to keep changes to the minimal needed for the following reasons:
* facilitating reviews;
* minimizing merge conflicts;
* keeping git history/blame clean.
Indeed the name `props` or `properties` could be slightly better but doing the rename now would add necessary noise to this PR so I prefer to keep it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238646465
##########
kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplierTest.java:
##########
@@ -75,13 +93,39 @@ public static void stopCluster() {
}
@Test
- public void testObtainTokenNotNull() {
+ public void testObtainTokenFromSamlPlainTextListenerNotNull() {
+ Properties props = new Properties();
+ props.setProperty("kafka.bootstrap.servers", KafkaBrokerResource.BROKER_SASL_PORT);
+ checkObtainToken(props);
+ }
+
+ @Test
+ public void testObtainTokenFromSamlSslListenerNotNull()
+ throws IOException, URISyntaxException, KeyStoreException, CertificateException, NoSuchAlgorithmException {
+ Properties props = new Properties();
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_BOOTSTRAP_SERVERS.getName(),
+ KafkaBrokerResource.BROKER_SASL_SSL_PORT);
+ // Should the SSL properties be divided between producer/consumer? Probably not!
+ props.setProperty(SECURITY_PROTOCOL_CONFIG, SecurityProtocol.SASL_SSL.name);
+ props.setProperty(SslConfigs.SSL_ENDPOINT_IDENTIFICATION_ALGORITHM_CONFIG, "");
+ String pwdAlias = "HereIsAnAliasForTheKeyWhichHoldsTheTrustorePassword";
+ URI storeURI = createCredentialStore(ImmutableMap.of(pwdAlias, KAFKA_BROKER_RESOURCE.getTruststorePwd()));
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_CREDENTIAL_KEYSTORE.getName(), storeURI.toString());
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_TRUSTSTORE_PASSWORD.getName(), pwdAlias);
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_KEYSTORE_PASSWORD.getName(), "");
+ props.setProperty(KafkaTableProperties.HIVE_KAFKA_SSL_KEY_PASSWORD.getName(), "");
+ String location = KAFKA_BROKER_RESOURCE.getTruststorePath().toUri().toString();
Review Comment:
Fixed in https://github.com/apache/hive/pull/4430/commits/6c2e197abbd34f508774836dc52731b196b95cc3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238653284
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -91,17 +89,13 @@ public Text getTokenAlias() {
*/
private boolean isTokenRequired(TableDesc tableDesc) {
String kafkaBrokers = (String) tableDesc.getProperties().get(HIVE_KAFKA_BOOTSTRAP_SERVERS.getName());
- String consumerSecurityProtocol = (String) tableDesc.getProperties().get(
- CONSUMER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- String producerSecurityProtocol = (String) tableDesc.getProperties().get(
- PRODUCER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
- return kafkaBrokers != null && !kafkaBrokers.isEmpty()
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(consumerSecurityProtocol)
- && !CommonClientConfigs.DEFAULT_SECURITY_PROTOCOL.equalsIgnoreCase(producerSecurityProtocol);
+ SecurityProtocol protocol = KafkaUtils.securityProtocol(tableDesc.getProperties());
+ return kafkaBrokers != null && !kafkaBrokers.isEmpty() && SecurityProtocol.PLAINTEXT != protocol;
Review Comment:
Fixed in https://github.com/apache/hive/pull/4430/commits/45dae3d856028593bab73a0b1810952309450758
In general I am not a very big fan of `StringUtils` because people tend to add the commons dep in projects/modules just for using this method. In this case it seems we already have the dep so it doesn't make much of a difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238628158
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -114,7 +108,12 @@ private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
Properties config = new Properties();
config.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG, kafkaBrokers);
- config.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, SecurityProtocol.SASL_PLAINTEXT.name);
+ SecurityProtocol protocol = KafkaUtils.securityProtocol(tableProperties);
+ if (protocol == null) {
+ protocol = SecurityProtocol.SASL_PLAINTEXT;
+ LOG.warn("Kafka security.protocol is undefined in table properties. Using default {}", protocol.name);
Review Comment:
I didn't want to put `SASL_PLAINTEXT` as a general default cause it doesn't make much sense and I didn't want to change the behavior of this part of the code to default to `PLAINTEXT` either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238654372
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaUtils.java:
##########
@@ -397,4 +421,31 @@ static void addKerberosJaasConf(Configuration configuration, Properties props) {
}
log.info("Kafka client running with following JAAS = [{}]", jaasConf);
}
+
+ /**
+ * Returns the security protocol if one is defined in the properties and null otherwise.
+ * <p>The following properties are examined to determine the protocol:</p>
+ * <ol>
+ * <li>security.protocol</li>
+ * <li>kafka.consumer.security.protocol</li>
+ * <li>kafka.producer.security.protocol</li>
+ * </ol>
+ * <p>and the first non null/not empty is returned.</p>
+ * <p>Defining multiple security protocols at the same time is invalid but this method is lenient and tries to pick
+ * the most reasonable option.</p>
+ * @param props the properties from which to obtain the protocol.
+ * @return the security protocol if one is defined in the properties and null otherwise.
+ */
+ static SecurityProtocol securityProtocol(Properties props) {
+ List<String> securityProtocolConfigs = Arrays.asList(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG,
+ CONSUMER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG,
+ PRODUCER_CONFIGURATION_PREFIX + "." + CommonClientConfigs.SECURITY_PROTOCOL_CONFIG);
Review Comment:
Fixed in https://github.com/apache/hive/pull/4430/commits/fcc14e85f07b69b43154911fe2ea766fdbc5c3fb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1238655326
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -123,6 +122,9 @@ private Token<?> getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
config.put(SaslConfigs.SASL_JAAS_CONFIG, jaasConfig);
LOG.debug("Jaas config for requesting kafka credentials: {}", jaasConfig);
+ Configuration copy = new Configuration(conf);
Review Comment:
Fixed in https://github.com/apache/hive/pull/4430/commits/cfb464b7dd9c3b1af9425b61e856082f388f84a9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4430:
URL: https://github.com/apache/hive/pull/4430#issuecomment-1603458361
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4430)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4430&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4430&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4430&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4430&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] akshat0395 commented on pull request #4430: HIVE-27374: Exception while getting kafka delegation tokens in Kerberos/SSL enabled clusters
Posted by "akshat0395 (via GitHub)" <gi...@apache.org>.
akshat0395 commented on PR #4430:
URL: https://github.com/apache/hive/pull/4430#issuecomment-1600455525
Minor comment, Changes LGTM +1, Thanks @zabetak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org