[jira] [Updated] (GUACAMOLE-2136) Improve guacd compliance with C standards

["Mike Jumper (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GUACAMOLE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Jumper updated GUACAMOLE-2136:
-----------------------------------
    Fix Version/s: 1.6.2 [patch]

> Improve guacd compliance with C standards
> -----------------------------------------
>
>                 Key: GUACAMOLE-2136
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-2136
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole-server
>            Reporter: Stephen Schiffli
>            Priority: Minor
>             Fix For: 1.6.2 [patch]
>
>
> I tried building with clang and hit some minor errors.
> {{cc --version}}
> {{Ubuntu clang version 18.1.3 (1ubuntu1)}}
> Almost all of the errors are in the form of: 
> {{error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]}}
> {{  117 | void guac_argv_stop();}}
> {{      |                    ^}}
> {{      |                     void}}
> It appears the strict-prototypes rule is part of clang pedantic but not gcc.  Obviously a few different ways to address this, but would be interested in the opinion of the maintainers for a style direction.  
> The only somewhat interesting find was a "set but not used variable"
> {{surface.c:1898:9: error: variable 'flushed' set but not used [-Werror,-Wunused-but-set-variable]}}
> {{ 1898 |     int flushed = 0;}}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)