[GitHub] [spark] kiszk commented on a change in pull request #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test

[GitBox <gi...@apache.org>]

kiszk commented on a change in pull request #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test
URL: https://github.com/apache/spark/pull/25243#discussion_r307227230
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
 ##########
 @@ -477,22 +476,18 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
   }
 
   test("withColumns: case sensitive") {
-    withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
-      val df = testData.toDF().withColumns(Seq("newCol1", "newCOL1"),
+    spark.sessionState.conf.setConf(SQLConf.CASE_SENSITIVE, true)
 
 Review comment:
   I agree with the idea of this PR.
   
   In the implementation, can we use the current APIs (e.g 'withSQLConf') as possible?
   It is easy to see the scope of the specified option and is less to change # of lines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org