You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/12 12:36:35 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request, #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
pan3793 opened a new pull request, #3966:
URL: https://github.com/apache/incubator-kyuubi/pull/3966
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
After some thought and some offline discussions, I propose to change the configuration key from `kyuubi.engine.pool.balance.policy` to `kyuubi.engine.pool.selectPolicy`.
And in the future if we introduce and properties for specific policy, e.g. supposing we have a engine selection policy named `LOAD`, the properties would be
```
kyuubi.engine.pool.selectPolicy.load.abc=xxxx
kyuubi.engine.pool.selectPolicy.load.xyz=xxxx
```
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3966:
URL: https://github.com/apache/incubator-kyuubi/pull/3966#discussion_r1047998512
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1646,10 +1646,12 @@ object KyuubiConf {
.createWithDefault(-1)
val ENGINE_POOL_BALANCE_POLICY: ConfigEntry[String] =
- buildConf("kyuubi.engine.pool.balance.policy")
- .doc("The balance policy of queries in engine pool.<ul>" +
- " <li>RANDOM - Randomly use the engine in the pool</li>" +
- " <li>POLLING - Polling use the engine in the pool</li> </ul>")
+ buildConf("kyuubi.engine.pool.selectPolicy")
+ .doc("The policy of selecting engine in a pool engine for session." +
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3966:
URL: https://github.com/apache/incubator-kyuubi/pull/3966#discussion_r1046621988
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1646,10 +1646,12 @@ object KyuubiConf {
.createWithDefault(-1)
val ENGINE_POOL_BALANCE_POLICY: ConfigEntry[String] =
- buildConf("kyuubi.engine.pool.balance.policy")
- .doc("The balance policy of queries in engine pool.<ul>" +
- " <li>RANDOM - Randomly use the engine in the pool</li>" +
- " <li>POLLING - Polling use the engine in the pool</li> </ul>")
+ buildConf("kyuubi.engine.pool.selectPolicy")
Review Comment:
Yea, this introduces the camel style to make the configuration key more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3966:
URL: https://github.com/apache/incubator-kyuubi/pull/3966#discussion_r1047003663
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1646,10 +1646,12 @@ object KyuubiConf {
.createWithDefault(-1)
val ENGINE_POOL_BALANCE_POLICY: ConfigEntry[String] =
- buildConf("kyuubi.engine.pool.balance.policy")
- .doc("The balance policy of queries in engine pool.<ul>" +
- " <li>RANDOM - Randomly use the engine in the pool</li>" +
- " <li>POLLING - Polling use the engine in the pool</li> </ul>")
+ buildConf("kyuubi.engine.pool.selectPolicy")
+ .doc("The policy of selecting engine in a pool engine for session." +
Review Comment:
The select policy of an engine from the corresponding engine pool engine for a session
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3966:
URL: https://github.com/apache/incubator-kyuubi/pull/3966#discussion_r1046570988
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1646,10 +1646,12 @@ object KyuubiConf {
.createWithDefault(-1)
val ENGINE_POOL_BALANCE_POLICY: ConfigEntry[String] =
- buildConf("kyuubi.engine.pool.balance.policy")
- .doc("The balance policy of queries in engine pool.<ul>" +
- " <li>RANDOM - Randomly use the engine in the pool</li>" +
- " <li>POLLING - Polling use the engine in the pool</li> </ul>")
+ buildConf("kyuubi.engine.pool.selectPolicy")
Review Comment:
seems kyuubi use `a.b.c` instead of camelbak, so just `kyuubi.engine.pool.policy` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3966:
URL: https://github.com/apache/incubator-kyuubi/pull/3966#issuecomment-1346428286
cc @ychris78 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3966:
URL: https://github.com/apache/incubator-kyuubi/pull/3966#issuecomment-1350374719
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3966: [KYUUBI #2887][FOLLOWUP] Rename configuration to kyuubi.engine.pool.selectPolicy
URL: https://github.com/apache/incubator-kyuubi/pull/3966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org