You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/08/17 14:27:32 UTC

[GitHub] [systemds] mar-volk opened a new pull request #1366: [SYSTEMDS-3097] Fix simple-aggregation-example

mar-volk opened a new pull request #1366:
URL: https://github.com/apache/systemds/pull/1366


   - See Jira ticket;
   
   - Without the change in line 85 the tutorial will not run.
   - The change in line 57 makes the script return the expected result.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1366: [SYSTEMDS-3097] Fix simple-aggregation-example

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1366:
URL: https://github.com/apache/systemds/pull/1366#issuecomment-900620993






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard closed pull request #1366: [SYSTEMDS-3097] Fix simple-aggregation-example

Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1366:
URL: https://github.com/apache/systemds/pull/1366


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1366: [SYSTEMDS-3097] Fix simple-aggregation-example

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1366:
URL: https://github.com/apache/systemds/pull/1366#issuecomment-903614916


   Thanks for pointing out an error in the CSV parsing when federated and the error in the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1366: [SYSTEMDS-3097] Fix simple-aggregation-example

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1366:
URL: https://github.com/apache/systemds/pull/1366#issuecomment-900621922


   > I don't think it is needed to add the header to the file csv file. But the federated line change indeed needs to happen. Thanks for the fix.
   
   Oh i see in the Jira task you found a bug. For reading the matrix when federated. We will have to address this specifically in another commit. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1366: [SYSTEMDS-3097] Fix simple-aggregation-example

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1366:
URL: https://github.com/apache/systemds/pull/1366#issuecomment-900620993


   I don't think it is needed to add the header to the file csv file. But the federated line change indeed needs to happen. Thanks for the  fix. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org