You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2015/09/14 17:33:42 UTC
hbase git commit: HBASE-14421 TestFastFail* are flakey;
ADDENDUM 3 Exclude another should assert in TestFastFail
Repository: hbase
Updated Branches:
refs/heads/master 99df022f2 -> 63a2fb514
HBASE-14421 TestFastFail* are flakey; ADDENDUM 3 Exclude another should assert in TestFastFail
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/63a2fb51
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/63a2fb51
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/63a2fb51
Branch: refs/heads/master
Commit: 63a2fb5143ab41d84b6b44001b63806534b26bdd
Parents: 99df022
Author: stack <st...@apache.org>
Authored: Mon Sep 14 08:32:52 2015 -0700
Committer: stack <st...@apache.org>
Committed: Mon Sep 14 08:32:52 2015 -0700
----------------------------------------------------------------------
.../java/org/apache/hadoop/hbase/client/TestFastFail.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/63a2fb51/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
index da31a7d..4121c16 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
@@ -268,14 +268,13 @@ public class TestFastFail {
assertEquals("The regionservers that returned true should equal to the"
+ " number of successful threads", numThreadsReturnedTrue,
numSuccessfullThreads.get());
- assertTrue(
- "There should be atleast one thread that retried instead of failing",
- MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);
-
/* 'should' is not worthy of an assert. Disabling because randomly this seems to randomly
* not but true. St.Ack 20151012
*
assertTrue(
+ "There should be atleast one thread that retried instead of failing",
+ MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);
+ assertTrue(
"There should be atleast one PreemptiveFastFail exception,"
+ " otherwise, the test makes little sense."
+ "numPreemptiveFastFailExceptions: "