You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/02/15 09:10:46 UTC
[GitHub] [jena] afs opened a new pull request #691: JENA-1840: Add --syntax
to tdbloader (TDB1 and TDB2)
afs opened a new pull request #691: JENA-1840: Add --syntax to tdbloader (TDB1 and TDB2)
URL: https://github.com/apache/jena/pull/691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a change in pull request #691:
JENA-1840: Add --syntax to tdbloader (TDB1 and TDB2)
Posted by GitBox <gi...@apache.org>.
rvesse commented on a change in pull request #691: JENA-1840: Add --syntax to tdbloader (TDB1 and TDB2)
URL: https://github.com/apache/jena/pull/691#discussion_r382046412
##########
File path: jena-cmds/src/main/java/tdb2/tdbloader.java
##########
@@ -92,6 +97,17 @@ else if ( loadername.matches("light") )
throw new CmdException("Not a boolean value: "+getValue(argStats));
generateStats = super.hasValueOfTrue(argStats);
}
+
+ if ( super.contains(argSyntax) ) {
+ String syntax = super.getValue(argSyntax) ;
+ Lang lang$ = RDFLanguages.nameToLang(syntax) ;
+ if ( lang$ == null )
+ throw new CmdException("Can not detemine the syntax from '" + syntax + "'") ;
+ this.lang = lang$ ;
+ }
+
+ if ( super.graphName != null )
Review comment:
So if I specify `--syntax=LANG` but also specify `--graph=URL` then my syntax spec is ignored?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #691: JENA-1840:
Add --syntax to tdbloader (TDB1 and TDB2)
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #691: JENA-1840: Add --syntax to tdbloader (TDB1 and TDB2)
URL: https://github.com/apache/jena/pull/691#discussion_r382075823
##########
File path: jena-cmds/src/main/java/tdb2/tdbloader.java
##########
@@ -92,6 +97,17 @@ else if ( loadername.matches("light") )
throw new CmdException("Not a boolean value: "+getValue(argStats));
generateStats = super.hasValueOfTrue(argStats);
}
+
+ if ( super.contains(argSyntax) ) {
+ String syntax = super.getValue(argSyntax) ;
+ Lang lang$ = RDFLanguages.nameToLang(syntax) ;
+ if ( lang$ == null )
+ throw new CmdException("Can not detemine the syntax from '" + syntax + "'") ;
+ this.lang = lang$ ;
+ }
+
+ if ( super.graphName != null )
Review comment:
Thanks for spotting that - default syntax should be set before `--syntax` is processed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #691: JENA-1840: Add --syntax to
tdbloader (TDB1 and TDB2)
Posted by GitBox <gi...@apache.org>.
afs merged pull request #691: JENA-1840: Add --syntax to tdbloader (TDB1 and TDB2)
URL: https://github.com/apache/jena/pull/691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org