You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Alexey Panchenko (JIRA)" <ji...@apache.org> on 2006/08/31 10:44:24 UTC

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

    [ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12431832 ] 
            
Alexey Panchenko commented on VELOCITY-453:
-------------------------------------------

ASTMethod_IntrospectionCacheData_cache-v2.patch is the updated patch

> [PATCH] Fix IntrospectionCacheData caching
> ------------------------------------------
>
>                 Key: VELOCITY-453
>                 URL: http://issues.apache.org/jira/browse/VELOCITY-453
>             Project: Velocity
>          Issue Type: Bug
>          Components: Source
>    Affects Versions: 1.5
>            Reporter: Alexey Panchenko
>            Priority: Critical
>         Attachments: ASTMethod_IntrospectionCacheData_cache, ASTMethod_IntrospectionCacheData_cache-v2.patch, IntrospectionCacheDataTest.java
>
>
> The old code used Class[].hashCode() in MethodCacheKey.hashCode() implementation.
> hashCode() is not overriden for arrays so it returns different value for each array instance.
> The attached is the correct implementation and a test case to prove the caching actually works.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org