You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/24 23:10:34 UTC

[commons-net] 02/02: Declare and initialize local variables at the same time

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git

commit 355f4f205b27b3b554cd2a19c7dd7bb28cf78671
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jun 24 19:10:28 2023 -0400

    Declare and initialize local variables at the same time
---
 src/main/java/org/apache/commons/net/time/TimeUDPClient.java | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/apache/commons/net/time/TimeUDPClient.java b/src/main/java/org/apache/commons/net/time/TimeUDPClient.java
index 37b10a9d..d595d09f 100644
--- a/src/main/java/org/apache/commons/net/time/TimeUDPClient.java
+++ b/src/main/java/org/apache/commons/net/time/TimeUDPClient.java
@@ -91,17 +91,13 @@ public final class TimeUDPClient extends DatagramSocketClient {
      * @throws IOException If an error occurs while retrieving the time.
      */
     public long getTime(final InetAddress host, final int port) throws IOException {
-        long time;
-        final DatagramPacket sendPacket;
-        final DatagramPacket receivePacket;
-
-        sendPacket = new DatagramPacket(dummyData, dummyData.length, host, port);
-        receivePacket = new DatagramPacket(timeData, timeData.length);
+        final DatagramPacket sendPacket = new DatagramPacket(dummyData, dummyData.length, host, port);
+        final DatagramPacket receivePacket = new DatagramPacket(timeData, timeData.length);
 
         checkOpen().send(sendPacket);
         checkOpen().receive(receivePacket);
 
-        time = 0L;
+        long time = 0L;
         time |= (((timeData[0] & 0xff) << 24) & 0xffffffffL);
         time |= (((timeData[1] & 0xff) << 16) & 0xffffffffL);
         time |= (((timeData[2] & 0xff) << 8) & 0xffffffffL);