You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/31 19:17:44 UTC
[GitHub] [couchdb-docker] wohali opened a new pull request #165: dev:
debian-buster, node 10, SM60
wohali opened a new pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165
## Overview
* Move dev and dev-cluster build to debian-buster
* Transition to node 10 from node 8
* Updated libicu to match
* Move to SM60
* Intended for use on amd64 and ppc64le only; arm will break with SM60
## GitHub issue number
Part of #163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-docker] wohali merged pull request #165: dev:
debian-buster, node 10, SM60
Posted by GitBox <gi...@apache.org>.
wohali merged pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-docker] wohali commented on a change in pull request #165:
dev: debian-buster, node 10, SM60
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375064130
##########
File path: dev/Dockerfile
##########
@@ -129,7 +129,7 @@ RUN ./configure
FROM build_dependencies AS build
ARG checkout_branch=master
-ARG configure_options
+ARG configure_options="-c --spidermonkey-version 60"
Review comment:
@kocolosk Yeah, I'm not sure how to handle this more elegantly; feel free to propose a solution. The default choice of `1.8.5` doesn't work in the image now that we're selectively only installing libmozjs-60, which was a conscious decision so I can gradually deprecate the 1.8.5 packages. But we can't make the new default 60 yet, since it will fail on just about every other OS at the moment.
Without `-c` you can't use the libcurl bindings in javascript, which developers arguably might want to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-docker] wohali commented on a change in pull request #165:
dev: debian-buster, node 10, SM60
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375064220
##########
File path: dev/Dockerfile
##########
@@ -111,16 +111,16 @@ RUN pip3 install --upgrade \
# Node is special
RUN set -ex; \
curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -; \
- echo 'deb https://deb.nodesource.com/node_8.x stretch main' > /etc/apt/sources.list.d/nodesource.list; \
- echo 'deb-src https://deb.nodesource.com/node_8.x stretch main' >> /etc/apt/sources.list.d/nodesource.list; \
+ echo 'deb https://deb.nodesource.com/node_10.x buster main' > /etc/apt/sources.list.d/nodesource.list; \
+ echo 'deb-src https://deb.nodesource.com/node_10.x buster main' >> /etc/apt/sources.list.d/nodesource.list; \
apt-get update -y && apt-get install -y nodejs; \
npm install -g grunt-cli
# Clone CouchDB source code including all dependencies
ARG clone_url=https://github.com/apache/couchdb.git
RUN git clone $clone_url /usr/src/couchdb
WORKDIR /usr/src/couchdb
-RUN ./configure
+RUN ./configure -c --spidermonkey-version 60
Review comment:
PRs welcome :wink:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-docker] wohali commented on issue #165: dev: debian-buster,
node 10, SM60
Posted by GitBox <gi...@apache.org>.
wohali commented on issue #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165#issuecomment-580872574
@willholley this should unblock https://github.com/apache/couchdb-docker/pull/158 I hope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-docker] kocolosk commented on a change in pull request
#165: dev: debian-buster, node 10, SM60
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375025684
##########
File path: dev/Dockerfile
##########
@@ -129,7 +129,7 @@ RUN ./configure
FROM build_dependencies AS build
ARG checkout_branch=master
-ARG configure_options
+ARG configure_options="-c --spidermonkey-version 60"
Review comment:
This is a little surprising because it gets dropped if a user specifies `configure_options` on the command line. I got bitten by it when my usual `--build-arg configure_options="--disable-docs"` invocation stopped working after this change.
Also, why specify `-c` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-docker] wohali commented on a change in pull request #165:
dev: debian-buster, node 10, SM60
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375064130
##########
File path: dev/Dockerfile
##########
@@ -129,7 +129,7 @@ RUN ./configure
FROM build_dependencies AS build
ARG checkout_branch=master
-ARG configure_options
+ARG configure_options="-c --spidermonkey-version 60"
Review comment:
@kocolosk Yeah, I'm not sure how to handle this more elegantly; feel free to propose a solution. The default choice of `1.8.5` doesn't work in the image now that we're selectively only installing libmozjs-60, which was a conscious decision so I can gradually deprecate the 1.8.5 packages. But we can't make the new default 60 in `./configure` yet, since it will fail on just about every other OS at the moment.
Without `-c` you can't use the libcurl bindings in javascript, which developers arguably might want to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-docker] kocolosk commented on a change in pull request
#165: dev: debian-buster, node 10, SM60
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #165: dev: debian-buster, node 10, SM60
URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375025233
##########
File path: dev/Dockerfile
##########
@@ -111,16 +111,16 @@ RUN pip3 install --upgrade \
# Node is special
RUN set -ex; \
curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -; \
- echo 'deb https://deb.nodesource.com/node_8.x stretch main' > /etc/apt/sources.list.d/nodesource.list; \
- echo 'deb-src https://deb.nodesource.com/node_8.x stretch main' >> /etc/apt/sources.list.d/nodesource.list; \
+ echo 'deb https://deb.nodesource.com/node_10.x buster main' > /etc/apt/sources.list.d/nodesource.list; \
+ echo 'deb-src https://deb.nodesource.com/node_10.x buster main' >> /etc/apt/sources.list.d/nodesource.list; \
apt-get update -y && apt-get install -y nodejs; \
npm install -g grunt-cli
# Clone CouchDB source code including all dependencies
ARG clone_url=https://github.com/apache/couchdb.git
RUN git clone $clone_url /usr/src/couchdb
WORKDIR /usr/src/couchdb
-RUN ./configure
+RUN ./configure -c --spidermonkey-version 60
Review comment:
Not sure adding the flags here was required; this invocation is only here to download base versions of dependencies to speed up subsequent builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services