You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@graphar.apache.org by "gary-cloud (via GitHub)" <gi...@apache.org> on 2025/09/10 07:01:35 UTC
[PR] feat: add date/timestamp test case [incubator-graphar-testing]
gary-cloud opened a new pull request, #31:
URL: https://github.com/apache/incubator-graphar-testing/pull/31
Add the datasets `ldbc_sample_date` and `ldbc_sample_timestamp`. In these datasets, the edges contain a `creationDate` property, defined with the data types `date` and `timestamp`, respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat: add date/timestamp test case [incubator-graphar-testing]
Posted by "gary-cloud (via GitHub)" <gi...@apache.org>.
gary-cloud commented on code in PR #31:
URL: https://github.com/apache/incubator-graphar-testing/pull/31#discussion_r2347800442
##########
ldbc_sample/parquet/person_knows_person.edge.yml:
##########
@@ -22,4 +22,16 @@ property_groups:
- name: creationDate
data_type: string
is_primary: false
+property_groups:
Review Comment:
It makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat: add date/timestamp test case [incubator-graphar-testing]
Posted by "gary-cloud (via GitHub)" <gi...@apache.org>.
gary-cloud commented on PR #31:
URL: https://github.com/apache/incubator-graphar-testing/pull/31#issuecomment-3289478596
hi @yangxk1, I have updated the PR to add the `createDate-date` attribute (of type **date**) and the `createDate-timestamp` attribute (of type **timestamp**) to **ldbc\_sample**, without affecting the original attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat: add date/timestamp test case [incubator-graphar-testing]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on code in PR #31:
URL: https://github.com/apache/incubator-graphar-testing/pull/31#discussion_r2347984992
##########
ldbc_sample/parquet/ldbc_sample.graph.yml:
##########
@@ -3,4 +3,6 @@ vertices:
- person.vertex.yml
edges:
- person_knows_person.edge.yml
+ - person_knows-timestamp_person.edge.yml
Review Comment:
pls use the new xxx.graph.yaml, because many tests are for graph tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat: add date/timestamp test case [incubator-graphar-testing]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on code in PR #31:
URL: https://github.com/apache/incubator-graphar-testing/pull/31#discussion_r2347741658
##########
ldbc_sample/parquet/person_knows_person.edge.yml:
##########
@@ -22,4 +22,16 @@ property_groups:
- name: creationDate
data_type: string
is_primary: false
+property_groups:
Review Comment:
It will be better to put it in a new yaml file e.g.,`person_knows_person_timestamps.edge.yml` & `ldbc_sample.graph.yml`, which will not affect the previous tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat: add date/timestamp test case [incubator-graphar-testing]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 merged PR #31:
URL: https://github.com/apache/incubator-graphar-testing/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] feat: add date/timestamp test case [incubator-graphar-testing]
Posted by "gary-cloud (via GitHub)" <gi...@apache.org>.
gary-cloud commented on PR #31:
URL: https://github.com/apache/incubator-graphar-testing/pull/31#issuecomment-3290859480
maybe it’ll look better after this update @yangxk1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org