You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Alex Couture-Beil <al...@mofo.ca> on 2014/05/01 01:26:24 UTC
Review Request 20927: Added metric to track the minimum offset for each
topic/partition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20927/
-----------------------------------------------------------
Review request for kafka.
Repository: kafka
Description
-------
Added metric to track the minimum offset for each topic/partition
Diffs
-----
core/src/main/scala/kafka/log/Log.scala f20c232e2daa63a10d91b965af52801af656477c
Diff: https://reviews.apache.org/r/20927/diff/
Testing
-------
Thanks,
Alex Couture-Beil
Re: Review Request 20927: Added metric to track the minimum offset for each
topic/partition
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20927/#review41897
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On April 30, 2014, 11:26 p.m., Alex Couture-Beil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20927/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:26 p.m.)
>
>
> Review request for kafka.
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Added metric to track the minimum offset for each topic/partition
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala f20c232e2daa63a10d91b965af52801af656477c
>
> Diff: https://reviews.apache.org/r/20927/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Couture-Beil
>
>
Re: Review Request 20927: Added metric to track the minimum offset for each
topic/partition
Posted by Alex Couture-Beil <al...@mofo.ca>.
> On May 1, 2014, 4:53 p.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/log/Log.scala, lines 458-459
> > <https://reviews.apache.org/r/20927/diff/1/?file=571972#file571972line458>
> >
> > Yes that's a good point - I can check this in with that edit.
you folks know best :) If logSegments is always sorted then that sounds good.
Thanks for looking over this.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20927/#review41923
-----------------------------------------------------------
On April 30, 2014, 11:26 p.m., Alex Couture-Beil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20927/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:26 p.m.)
>
>
> Review request for kafka.
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Added metric to track the minimum offset for each topic/partition
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala f20c232e2daa63a10d91b965af52801af656477c
>
> Diff: https://reviews.apache.org/r/20927/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Couture-Beil
>
>
Re: Review Request 20927: Added metric to track the minimum offset for each
topic/partition
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20927/#review41923
-----------------------------------------------------------
core/src/main/scala/kafka/log/Log.scala
<https://reviews.apache.org/r/20927/#comment75575>
Yes that's a good point - I can check this in with that edit.
- Joel Koshy
On April 30, 2014, 11:26 p.m., Alex Couture-Beil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20927/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:26 p.m.)
>
>
> Review request for kafka.
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Added metric to track the minimum offset for each topic/partition
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala f20c232e2daa63a10d91b965af52801af656477c
>
> Diff: https://reviews.apache.org/r/20927/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Couture-Beil
>
>
Re: Review Request 20927: Added metric to track the minimum offset for each
topic/partition
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20927/#review41916
-----------------------------------------------------------
core/src/main/scala/kafka/log/Log.scala
<https://reviews.apache.org/r/20927/#comment75570>
Wouldn't it be cheaper to do logSegments.head.baseOffset?
- Jun Rao
On April 30, 2014, 11:26 p.m., Alex Couture-Beil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20927/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:26 p.m.)
>
>
> Review request for kafka.
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Added metric to track the minimum offset for each topic/partition
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/Log.scala f20c232e2daa63a10d91b965af52801af656477c
>
> Diff: https://reviews.apache.org/r/20927/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Couture-Beil
>
>