You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/03/28 15:42:51 UTC
[Bug 121975] New: docx import patch: fixing table width (relative
table width is now supported)
https://issues.apache.org/ooo/show_bug.cgi?id=121975
Bug ID: 121975
Issue Type: DEFECT
Summary: docx import patch: fixing table width (relative table
width is now supported)
Classification: Application
Product: Writer
Version: AOO400-dev
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: code
Assignee: issues@openoffice.apache.org
Reporter: Sven-Jacobi@gmx.de
CC: issues@openoffice.apache.org
My patch fixes a docx import table width problem. In the current AOO version
relative table width is ignored, instead the table width is determined by the
grid array. But this is wrong, the code assumes that the grid array contains
Twip measurement values ... instead grid entries are specified to be relative
values... A grid array of "1:2:1" should produce the same table as if the grid
array would be "3:6:3".
This bug most probably also fixes 76425.
The patch resolves this problem, I make it available to AOO under ALv2..
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121975] docx import patch: fixing table width (relative table
width is now supported)
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121975
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ACCEPTED
Assignee|issues@openoffice.apache.or |orw@apache.org
|g |
Ever confirmed|0 |1
--- Comment #3 from Oliver-Rainer Wittmann <or...@apache.org> ---
taking over for patch review and integration
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121975] docx import patch: fixing table width (relative table
width is now supported)
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121975
--- Comment #5 from Sven Jacobi <Sv...@gmx.de> ---
Sorry Oliver, I have no time at the moment, so it might be best to close this
issue.. But I can tell you of my experience with the docx filter in OO. I think
that the filter is far away from being maintainable. In my opinion the best
would be to dump this code to trash and start rewriting it. The domainmapper in
writerfilter is like hell, each new feature let you break out in a sweat.
It is really hard stuff, there are a many factories created from a mysterious 1
mb large model.xml, lots of wrapper classes that wraps other wrapper classes...
no documentation at all and of course you won't ever get a sense of delight if
you debug the writer filter code.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121975] docx import patch: fixing table width (relative table
width is now supported)
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121975
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orw@apache.org
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121975] docx import patch: fixing table width (relative table
width is now supported)
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121975
--- Comment #1 from Sven Jacobi <Sv...@gmx.de> ---
Created attachment 80476
--> https://issues.apache.org/ooo/attachment.cgi?id=80476&action=edit
patch, fixing table width
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121975] docx import patch: fixing table width (relative table
width is now supported)
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121975
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |CONFIRMED
Assignee|orw@apache.org |Sven-Jacobi@gmx.de
--- Comment #4 from Oliver-Rainer Wittmann <or...@apache.org> ---
@Sven Jacobi:
The patch does not fix the problem.
It looks like that handling of newly introduced
TablePropertyMap::TABLE_WIDTH_TYPE is missing.
Also the overwrite of TablePropertyMap::TABLE_WIDTH in
<DomainMapperTableManager::endOfRowAction()> is not considering an already set
TablePropertyMap::TABLE_WIDTH_TYPE.
Can you please revise your patch? Thx in advance.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121975] docx import patch: fixing table width (relative table
width is now supported)
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121975
--- Comment #2 from Sven Jacobi <Sv...@gmx.de> ---
Created attachment 80477
--> https://issues.apache.org/ooo/attachment.cgi?id=80477&action=edit
bugdoc, containing a table that is displayed with the wrong width
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121975] docx import patch: fixing table width (relative table
width is now supported)
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121975
stx123@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stx123@gmail.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.