[jira] [Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087336#comment-16087336 ] 

ASF GitHub Bot commented on MNG-6256:
-------------------------------------

GitHub user etzelc opened a pull request:

    https://github.com/apache/maven/pull/128

    [MNG-6256] Surround variables in echo command with double quotes

    This is a patch for issue MNG-6256. https://issues.apache.org/jira/browse/MNG-6256

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/etzelc/maven MNG-6256

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit f578a733ade77c3d11186c395d1d5199a65f532d
Author: Christoph Etzel <ch...@informatik.uni-augsburg.de>
Date:   2017-07-14T08:26:06Z

    [MNG-6256] Surround variables in echo command with double quotes

----


> Maven script can break if "-f" path contains special characters 
> ----------------------------------------------------------------
>
>                 Key: MNG-6256
>                 URL: https://issues.apache.org/jira/browse/MNG-6256
>             Project: Maven
>          Issue Type: Bug
>          Components: Command Line
>    Affects Versions: 3.5.0
>         Environment: Windows 10 with PowerShell
>            Reporter: Christoph Etzel
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to specify an alternate POM file can break the script if the path contains special characters. 
> It was originally discovered on a Windows Jenkins instance with working directory located under C:\Program Files (x86)\Jenkins......
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)