You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/04 10:20:17 UTC
[GitHub] [iceberg] zhangdove opened a new pull request #2024: Remove unused test code in TestExpireSnapshotsAction
zhangdove opened a new pull request #2024:
URL: https://github.com/apache/iceberg/pull/2024
Restudy the test case code of ExpireSnapshotsAction and find some unused code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhangdove commented on pull request #2024: Remove unused test code in TestExpireSnapshotsAction
Posted by GitBox <gi...@apache.org>.
zhangdove commented on pull request #2024:
URL: https://github.com/apache/iceberg/pull/2024#issuecomment-754332257
Thank you for your advice. I also noticed that the #1380 is to solve the problem of jet lag.
Close it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhangdove closed pull request #2024: Remove unused test code in TestExpireSnapshotsAction
Posted by GitBox <gi...@apache.org>.
zhangdove closed pull request #2024:
URL: https://github.com/apache/iceberg/pull/2024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2024: Remove unused test code in TestExpireSnapshotsAction
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2024:
URL: https://github.com/apache/iceberg/pull/2024#issuecomment-754305700
I don't think that these changes are correct. The method that waits until after the last commit is intended to ensure that the timestamps work with the test assumptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org