You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/01/13 12:53:31 UTC

[GitHub] [drill] cgivre commented on a change in pull request #2426: DRILL-8106: do not use cellIterator because it skips empty cells

cgivre commented on a change in pull request #2426:
URL: https://github.com/apache/drill/pull/2426#discussion_r783463505



##########
File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -312,41 +311,31 @@ private void getColumnHeaders(SchemaBuilder builder) {
     //If there are no headers, create columns names of field_n
     if (readerConfig.headerRow == -1) {
       String missingFieldName;
-      int i = 0;
 
-      for (Cell c : currentRow) {
-        missingFieldName = MISSING_FIELD_NAME_HEADER + (i + 1);
+      for (short colNum = 0; colNum < currentRow.getLastCellNum(); colNum++) {

Review comment:
       Is there a reason why we're using a `short` here rather than an `int`?  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org