You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2026/02/19 10:22:24 UTC
[PR] fix(db-modal): update doc refs for DB connection modal [superset]
hainenber opened a new pull request, #38091:
URL: https://github.com/apache/superset/pull/38091
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
fix(db-modal): update doc refs for DB connection modal
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
There were a few references to Superset's docs not yet updated after massive revamp for Docs v2. This PR is to rectify such issue.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Old URLs lead to 404 whilst new ones are correct. One can access the URLs for verification
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3988101371
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #38091:
URL: https://github.com/apache/superset/pull/38091#discussion_r2826925477
##########
superset-frontend/src/features/databases/DatabaseModal/ModalHeader.tsx:
##########
@@ -33,12 +33,12 @@ const supersetTextDocs = getDatabaseDocumentationLinks();
export const DOCUMENTATION_LINK = supersetTextDocs
? supersetTextDocs.support
- : 'https://superset.apache.org/docs/configuration/databases#installing-database-drivers';
+ : 'https://superset.apache.org/docs/databases/#installing-database-drivers';
const irregularDocumentationLinks = {
postgresql: 'https://superset.apache.org',
- mssql: 'https://superset.apache.org/docs/databases/sql-server',
- gsheets: 'https://superset.apache.org/docs/databases/google-sheets',
+ mssql: 'https://superset.apache.org/docs/databases/supported/sql-server',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect Documentation URL</b></div>
<div id="fix">
The documentation URL for Microsoft SQL Server points to a 404 page. Based on the official Superset documentation structure, it should include 'microsoft-' in the path.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
mssql: 'https://superset.apache.org/docs/databases/supported/microsoft-sql-server',
````
</div>
</details>
</div>
<small><i>Code Review Run #a60b37</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3987899929
## **Sequence Diagram**
Shows how the DB connection modal resolves which documentation URL to display. The PR updates fallback and per-engine doc URLs so the modal links to new Docs v2 locations.
```mermaid
sequenceDiagram
participant User
participant UI as DB Modal
participant Frontend as ModalHeader
participant Docs as Documentation Site
User->>UI: Open "Add / Edit Database" modal
UI->>Frontend: Request documentation link for engine (e.g., mssql, gsheets)
Frontend->>Frontend: getDatabaseDocumentationLinks() or use FALLBACK + irregularOverrides
Frontend-->>UI: Return resolved documentation URL (updated user-docs path)
UI-->>User: Render "View docs" link pointing to Docs
User->>Docs: Click link -> navigate to updated Docs URL
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3940264618
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #38091:
URL: https://github.com/apache/superset/pull/38091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3935733344
## **Sequence Diagram**
Shows how the Database modal header resolves and displays the documentation link for a selected database engine. The PR updates fallback URLs for certain engines so the modal points to the new Docs v2 locations.
```mermaid
sequenceDiagram
participant User
participant Browser
participant Frontend
participant DocsSite
User->>Browser: Open "Add / Edit Database" modal
Browser->>Frontend: Render ModalHeader (engine selected)
Frontend->>Frontend: getDatabaseDocumentationLinks() -> supersetTextDocs?
alt supersetTextDocs available
Frontend-->>Browser: Use supersetTextDocs[engine] or default link
else fallback to built-in mapping
Frontend-->>Browser: Use irregularDocumentationLinks[engine] (updated URLs) or generic docs link
end
Browser->>User: Display "View documentation" link (points to DocsSite)
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3926244011
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3926250684
## **Sequence Diagram**
Shows how the Database connection modal resolves and opens the correct documentation URL after doc-v2 updates. The ModalHeader fetches doc mappings, applies engine-specific overrides (including updated irregular links), and navigates the user to the resolved docs URL.
```mermaid
sequenceDiagram
participant User
participant ModalHeader
participant DocsResolver
participant Browser
User->>ModalHeader: Open "Add / Edit Database" modal
ModalHeader->>DocsResolver: getDatabaseDocumentationLinks() (load superset_text docs)
DocsResolver-->>ModalHeader: supersetTextDocs (or null)
ModalHeader->>DocsResolver: resolve documentationLink(engine) (apply irregular overrides e.g., mssql, gsheets)
DocsResolver-->>ModalHeader: resolved docs URL (updated docs v2 paths)
ModalHeader->>Browser: Open resolved docs URL (user clicks "Documentation")
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3926692551
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #38091:
URL: https://github.com/apache/superset/pull/38091#discussion_r2874064145
##########
superset-frontend/src/features/databases/DatabaseModal/ModalHeader.tsx:
##########
@@ -33,12 +33,13 @@ const supersetTextDocs = getDatabaseDocumentationLinks();
export const DOCUMENTATION_LINK = supersetTextDocs
? supersetTextDocs.support
- : 'https://superset.apache.org/docs/configuration/databases#installing-database-drivers';
+ : 'https://superset.apache.org/user-docs/databases/#installing-database-drivers';
const irregularDocumentationLinks = {
postgresql: 'https://superset.apache.org',
- mssql: 'https://superset.apache.org/docs/databases/sql-server',
- gsheets: 'https://superset.apache.org/docs/databases/google-sheets',
+ mssql:
+ 'https://superset.apache.org/docs/databases/supported/microsoft-sql-server',
Review Comment:
```suggestion
'https://superset.apache.org/user-docs/databases/supported/microsoft-sql-server',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3986192020
## **Sequence Diagram**
When a user needs help connecting a database, the modal resolves and displays the appropriate documentation URL based on the database engine type. This PR updates those URLs to point to the new Superset Docs v2 locations.
```mermaid
sequenceDiagram
participant User
participant DBModal as Database Modal
participant DocResolver as Documentation Link Resolver
participant External as Superset Docs
User->>DBModal: Open database connection modal
DBModal->>DocResolver: Get help link for engine (e.g., mssql, gsheets)
DocResolver->>DocResolver: Lookup irregularDocumentationLinks or<br/>fall back to default URL
DocResolver-->>DBModal: Return updated documentation URL
User->>DBModal: Click "connecting to [database]" help link
DBModal->>External: Navigate to Superset documentation
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #38091:
URL: https://github.com/apache/superset/pull/38091#discussion_r2875452367
##########
superset-frontend/src/features/databases/DatabaseModal/ModalHeader.tsx:
##########
@@ -33,12 +33,13 @@ const supersetTextDocs = getDatabaseDocumentationLinks();
export const DOCUMENTATION_LINK = supersetTextDocs
? supersetTextDocs.support
- : 'https://superset.apache.org/docs/configuration/databases#installing-database-drivers';
+ : 'https://superset.apache.org/user-docs/databases/#installing-database-drivers';
const irregularDocumentationLinks = {
postgresql: 'https://superset.apache.org',
- mssql: 'https://superset.apache.org/docs/databases/sql-server',
- gsheets: 'https://superset.apache.org/docs/databases/google-sheets',
+ mssql:
+ 'https://superset.apache.org/user-docs/databases/supported/microsoft-sql-server',
+ gsheets: 'https://superset.apache.org/user-docs/databases/supported/google-sheets',
Review Comment:
```suggestion
mssql:
'https://superset.apache.org/user-docs/databases/supported/microsoft-sql-server',
gsheets:
'https://superset.apache.org/user-docs/databases/supported/google-sheets',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #38091:
URL: https://github.com/apache/superset/pull/38091#discussion_r2874065541
##########
superset-frontend/src/features/databases/DatabaseModal/ModalHeader.tsx:
##########
@@ -33,12 +33,13 @@ const supersetTextDocs = getDatabaseDocumentationLinks();
export const DOCUMENTATION_LINK = supersetTextDocs
? supersetTextDocs.support
- : 'https://superset.apache.org/docs/configuration/databases#installing-database-drivers';
+ : 'https://superset.apache.org/user-docs/databases/#installing-database-drivers';
const irregularDocumentationLinks = {
postgresql: 'https://superset.apache.org',
- mssql: 'https://superset.apache.org/docs/databases/sql-server',
- gsheets: 'https://superset.apache.org/docs/databases/google-sheets',
+ mssql:
+ 'https://superset.apache.org/docs/databases/supported/microsoft-sql-server',
+ gsheets: 'https://superset.apache.org/docs/databases/supported/google-sheets',
Review Comment:
```suggestion
gsheets: 'https://superset.apache.org/user-docs/databases/supported/google-sheets',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #38091:
URL: https://github.com/apache/superset/pull/38091#discussion_r2874062796
##########
superset-frontend/src/features/databases/DatabaseModal/ModalHeader.tsx:
##########
@@ -33,12 +33,13 @@ const supersetTextDocs = getDatabaseDocumentationLinks();
export const DOCUMENTATION_LINK = supersetTextDocs
? supersetTextDocs.support
- : 'https://superset.apache.org/docs/configuration/databases#installing-database-drivers';
+ : 'https://superset.apache.org/docs/databases/#installing-database-drivers';
Review Comment:
```suggestion
: 'https://superset.apache.org/user-docs/databases/#installing-database-drivers';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3986221713
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | dc1edef8f2c85cac349b01406b6057c41406608d |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69a5da2227dcfa0008d8b0cd |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-38091--superset-docs-preview.netlify.app](https://deploy-preview-38091--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-38091--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(db-modal): update doc refs for DB connection modal [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38091:
URL: https://github.com/apache/superset/pull/38091#issuecomment-3986515389
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org