[jira] [Commented] (ARTEMIS-579) JAAS files should be reloaded when they change

["Lionel Cons (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339192#comment-15339192 ] 

Lionel Cons commented on ARTEMIS-579:
-------------------------------------

Looking at the code, it seems that the functionality is present (via {{reload=true}}) but not documented. Please document it.

Also, {{TextFileCertificateLoginModule.java}} contains:

{code}
 * The user and role files' locations must be specified in the
 * org.apache.activemq.jaas.textfiledn.user and
 * org.apache.activemq.jaas.textfiledn.role properties respectively. NOTE: This
 * class will re-read user and group files for every authentication (i.e it does
 * live updates of allowed roles and users).
{code}

Could you please confirm that Artemis will *not* re-read user and group files for every authentication but only when the files change? In this case, the comment in the code should be changed...

> JAAS files should be reloaded when they change
> ----------------------------------------------
>
>                 Key: ARTEMIS-579
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-579
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Lionel Cons
>
> If a JAAS file (e.g. {{users.properties}}) is changed after the broker starts, its new contents does not seem to be used.
> ActiveMQ 5.x does support JAAS file reloading, see http://activemq.apache.org/security.html.
> For efficiency reasons, the file should only be reloaded if its modification time changes since the last load.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)