You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/08 09:24:22 UTC

[GitHub] [fineract] fynmanoj opened a new pull request #1966: FINERACT-1414 : change-premitive-type-to-handle-null

fynmanoj opened a new pull request #1966:
URL: https://github.com/apache/fineract/pull/1966


   ## Description
   
   Describe the changes made and why they were made.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola removed a comment on pull request #1966: FINERACT-1414 : change-premitive-type-to-handle-null

Posted by GitBox <gi...@apache.org>.
ptuomola removed a comment on pull request #1966:
URL: https://github.com/apache/fineract/pull/1966#issuecomment-963030148


   Hi @fynmanoj - is the JIRA reference for this correct? FINERACT-1414 seems to be already closed and not sure if it's related to this...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola merged pull request #1966: FINERACT-1414 : change-premitive-type-to-handle-null

Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1966:
URL: https://github.com/apache/fineract/pull/1966


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1966: FINERACT-1414 : change-premitive-type-to-handle-null

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1966:
URL: https://github.com/apache/fineract/pull/1966#issuecomment-963032846


   Build and tests passing - looks good to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] fynmanoj commented on pull request #1966: FINERACT-1414 : change-premitive-type-to-handle-null

Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #1966:
URL: https://github.com/apache/fineract/pull/1966#issuecomment-963036355


   @ptuomola , This is related to FINERACT-1414, which missed to handle null cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1966: FINERACT-1414 : change-premitive-type-to-handle-null

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1966:
URL: https://github.com/apache/fineract/pull/1966#issuecomment-963030148


   Hi @fynmanoj - is the JIRA reference for this correct? FINERACT-1414 seems to be already closed and not sure if it's related to this...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org