You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by da...@apache.org on 2023/06/21 08:16:13 UTC
[doris] branch master updated: [enhancement](merge-on-write) some misc optimizations (#21039)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 85ce6a22c0 [enhancement](merge-on-write) some misc optimizations (#21039)
85ce6a22c0 is described below
commit 85ce6a22c0ecc47c83cb621040471bf1d56e8c62
Author: zhannngchen <48...@users.noreply.github.com>
AuthorDate: Wed Jun 21 16:16:06 2023 +0800
[enhancement](merge-on-write) some misc optimizations (#21039)
---
be/src/olap/primary_key_index.cpp | 9 +++++----
be/src/olap/rowset/segment_v2/segment.cpp | 3 ---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/be/src/olap/primary_key_index.cpp b/be/src/olap/primary_key_index.cpp
index 3f30529732..7b2f1593ca 100644
--- a/be/src/olap/primary_key_index.cpp
+++ b/be/src/olap/primary_key_index.cpp
@@ -40,14 +40,15 @@ Status PrimaryKeyIndexBuilder::init() {
options.write_value_index = true;
options.data_page_size = config::primary_key_data_page_size;
options.encoding = segment_v2::EncodingInfo::get_default_encoding(type_info, true);
- // TODO(liaoxin) test to confirm whether it needs to be compressed
- options.compression = segment_v2::NO_COMPRESSION; // currently not compressed
+ options.compression = segment_v2::ZSTD;
_primary_key_index_builder.reset(
new segment_v2::IndexedColumnWriter(options, type_info, _file_writer));
RETURN_IF_ERROR(_primary_key_index_builder->init());
- _bloom_filter_index_builder.reset(new segment_v2::PrimaryKeyBloomFilterIndexWriterImpl(
- segment_v2::BloomFilterOptions(), type_info));
+ auto opt = segment_v2::BloomFilterOptions();
+ opt.fpp = 0.01;
+ _bloom_filter_index_builder.reset(
+ new segment_v2::PrimaryKeyBloomFilterIndexWriterImpl(opt, type_info));
return Status::OK();
}
diff --git a/be/src/olap/rowset/segment_v2/segment.cpp b/be/src/olap/rowset/segment_v2/segment.cpp
index 50dc44ee73..70ac2c108e 100644
--- a/be/src/olap/rowset/segment_v2/segment.cpp
+++ b/be/src/olap/rowset/segment_v2/segment.cpp
@@ -73,8 +73,6 @@ class InvertedIndexIterator;
using io::FileCacheManager;
-static bvar::LatencyRecorder g_segment_lookup_rowkey_latency("doris_pk", "segment_lookup_rowkey");
-
Status Segment::open(io::FileSystemSPtr fs, const std::string& path, uint32_t segment_id,
RowsetId rowset_id, TabletSchemaSPtr tablet_schema,
const io::FileReaderOptions& reader_options,
@@ -358,7 +356,6 @@ Status Segment::new_inverted_index_iterator(const TabletColumn& tablet_column,
}
Status Segment::lookup_row_key(const Slice& key, bool with_seq_col, RowLocation* row_location) {
- SCOPED_BVAR_LATENCY(g_segment_lookup_rowkey_latency);
RETURN_IF_ERROR(load_pk_index_and_bf());
bool has_seq_col = _tablet_schema->has_sequence_col();
size_t seq_col_length = 0;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org