You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/02 22:26:04 UTC
[GitHub] [tvm] tkonolige opened a new pull request #7570: [RUNTIME] Move Map into runtime
tkonolige opened a new pull request #7570:
URL: https://github.com/apache/tvm/pull/7570
This allows us to use Map to store parameters needed at runtime. Needed for #7559.
@junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on a change in pull request #7570: [RUNTIME] Move Map into runtime
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #7570:
URL: https://github.com/apache/tvm/pull/7570#discussion_r585967568
##########
File path: include/tvm/arith/bound.h
##########
@@ -25,7 +25,7 @@
#include <tvm/arith/int_set.h>
#include <tvm/ir/expr.h>
-#include <tvm/node/container.h>
Review comment:
@junrushao1994 can we remove the node subdirectory now? seems to be out-dated naming now that we are in object land?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #7570: [RUNTIME] Move Map into runtime
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #7570:
URL: https://github.com/apache/tvm/pull/7570#discussion_r585981680
##########
File path: include/tvm/arith/bound.h
##########
@@ -25,7 +25,7 @@
#include <tvm/arith/int_set.h>
#include <tvm/ir/expr.h>
-#include <tvm/node/container.h>
Review comment:
The node subdir still contains a lot of useful stuff, like structural hash and reflection, etc. Removing node/container.h looks good to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #7570: [RUNTIME] Move Map into runtime
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #7570:
URL: https://github.com/apache/tvm/pull/7570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org