You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (Jira)" <ji...@apache.org> on 2025/12/26 17:29:00 UTC
[jira] [Commented] (HTTPCORE-790) Should not set push_enable for the H2Config for H2ServerBootstrap
[ https://issues.apache.org/jira/browse/HTTPCORE-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18047676#comment-18047676 ]
Oleg Kalnichevski commented on HTTPCORE-790:
--------------------------------------------
[~cooltomatos] The H2 server does accept `H2Config` with push enabled but it _does not_ send this setting to the client during the settings handshake as per RFC 9113. Please see [1]. So, there is no protocol violation.
I am fine with rejecting H2 config with push enabled as proposed here [2]
Oleg
[1] [https://github.com/apache/httpcomponents-core/blob/master/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ServerH2StreamMultiplexer.java#L96]
[2] [https://github.com/apache/httpcomponents-core/pull/591]
> Should not set push_enable for the H2Config for H2ServerBootstrap
> -----------------------------------------------------------------
>
> Key: HTTPCORE-790
> URL: https://issues.apache.org/jira/browse/HTTPCORE-790
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Reporter: Shang Xiang
> Priority: Major
>
> According to [RFC 9113 - 6.5.2|https://www.rfc-editor.org/rfc/rfc9113.html#name-defined-settings]
> A server should never set {{SETTINGS_PUSH_ENABLE}} to true.
> However, currently in {{H2ServerBoostrap}}, we are accepting configs with it enabled, and when a config is not provided, we are taking {{H2Config.DEFAULT}}, which has it enabled as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org