You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by "Pill, Juergen" <Ju...@softwareag.com> on 2000/11/23 19:38:34 UTC

Slide lock and security performance

In following code snipplet from ContentImpl . create the last 2 calls are
redundant to my opinion, if
namespaceConfig.getCreateRevisionMetadataAction() and
namespaceConfig.getCreateRevisionContentAction() are identical. What do you
think to perform the 2 last method calls only, if these pointer are
different?


        // Next we do a security check and a locking check for
modifyRevisions
        securityHelper.checkCredentials
            (token, associatedObject,
             namespaceConfig.getCreateRevisionMetadataAction());
        lockHelper.checkLock
            (token, associatedObject,
             namespaceConfig.getCreateRevisionMetadataAction());
        securityHelper.checkCredentials
            (token, associatedObject,
             namespaceConfig.getCreateRevisionContentAction());
        lockHelper.checkLock(token, associatedObject,
 
namespaceConfig.getCreateRevisionContentAction());

Best regards

Juergen Pill

Re: Slide lock and security performance

Posted by Remy Maucherat <re...@apache.org>.
> In following code snipplet from ContentImpl . create the last 2 calls are
> redundant to my opinion, if
> namespaceConfig.getCreateRevisionMetadataAction() and
> namespaceConfig.getCreateRevisionContentAction() are identical. What do
you
> think to perform the 2 last method calls only, if these pointer are
> different?
>
>
>         // Next we do a security check and a locking check for
> modifyRevisions
>         securityHelper.checkCredentials
>             (token, associatedObject,
>              namespaceConfig.getCreateRevisionMetadataAction());
>         lockHelper.checkLock
>             (token, associatedObject,
>              namespaceConfig.getCreateRevisionMetadataAction());
>         securityHelper.checkCredentials
>             (token, associatedObject,
>              namespaceConfig.getCreateRevisionContentAction());
>         lockHelper.checkLock(token, associatedObject,
>
> namespaceConfig.getCreateRevisionContentAction());

Yes, I guess adding the check is simple enough :)

Remy