You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tvm.apache.org by Siyuan Feng <no...@github.com.INVALID> on 2021/10/06 14:20:58 UTC

[apache/tvm-rfcs] [RFC] Update script block syntax (#41)

It&#39;s the rfc for a new block syntax in TVMScript.

Co-authored-by: Junru Shao &lt;junrushao1994@gmail.com&gt;
Co-authored-by: Zihao Ye &lt;zihaoye.cs@gmail.com&gt;
Co-authored-by: Tianqi Chen &lt;tqchen@users.noreply.github.com&gt;

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/tvm-rfcs/pull/41

-- Commit Summary --

  * <a href="https://github.com/apache/tvm-rfcs/pull/41/commits/cce29db60fd2b46538c1e21c8ca82e4b1212258e">init block syntax rfc</a>

-- File Changes --

    A rfcs/0041-script-block-syntax.md (142)

-- Patch Links --

https://github.com/apache/tvm-rfcs/pull/41.patch
https://github.com/apache/tvm-rfcs/pull/41.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/41

Re: [apache/tvm-rfcs] [RFC] Update script block syntax (#41)

Posted by Junru Shao <no...@github.com.INVALID>.

The syntax of block bindings looks good to me! Specially it makes it really clear to the readers that there is a "block binding" to avoid future surprise.

BTW, do we have a reference for the behavior of auto-completion on T.read/write?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/41#issuecomment-936887553

Re: [apache/tvm-rfcs] [RFC] Update script block syntax (#41)

Posted by Junru Shao <no...@github.com.INVALID>.

I don't have other comments :-)  Going to merge this RFC in 24h if there is no objection

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/41#issuecomment-939069224

Re: [apache/tvm-rfcs] [RFC] Update script block syntax (#41)

Posted by Tianqi Chen <no...@github.com.INVALID>.

THanks @Hzfengsy , looks like a great update that makes the intend clear

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/41#issuecomment-938152672

Re: [apache/tvm-rfcs] [RFC] Update script block syntax (#41)

Posted by Tianqi Chen <no...@github.com.INVALID>.

Merged #41 into main.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/41#event-5438527567

Re: [apache/tvm-rfcs] [RFC] Update script block syntax (#41)

Posted by Siyuan Feng <no...@github.com.INVALID>.

Thanks @junrushao1994. The reference has updated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/41#issuecomment-937708016

Re: [apache/tvm-rfcs] [RFC] Update script block syntax (#41)

Posted by Junru Shao <no...@github.com.INVALID>.

Rendered text: https://github.com/apache/tvm-rfcs/blob/67df92fea29d4e667adfe149d7b2b1420c344b47/rfcs/0041-script-block-syntax.md

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/41#issuecomment-936712366