[jira] [Commented] (FLINK-20605) DeclarativeSlotManager crashes if slot allocation notification is processed out-of-order

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-20605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249791#comment-17249791 ] 

Chesnay Schepler commented on FLINK-20605:
------------------------------------------

Similar issue with 3); a slot report overtaking the acknowledge results in a repeated attempt at transitioning to allocated.

> DeclarativeSlotManager crashes if slot allocation notification is processed out-of-order
> ----------------------------------------------------------------------------------------
>
>                 Key: FLINK-20605
>                 URL: https://issues.apache.org/jira/browse/FLINK-20605
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.13.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.13.0
>
>
> It is possible that a notification from a task executor about a slot being allocated can be processed after that very task executor has unregistered itself from the resource manager.
> As a result we run into an exception when trying to mark this slot as allocated, because it no longer exists and a precondition catches this case.
> We could solve this by checking in {{DeclarativeResourceManager#allocateSlot}} whether the task executor we received the acknowledge from is still registered.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)