[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3888: arch: Colorize the idle thread stack in an unified way

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on pull request #3888:
URL: https://github.com/apache/incubator-nuttx/pull/3888#issuecomment-858617882


   > 
   > @xiaoxiang781216 Do you feel the unification is more important than the benefit of the early debugging?
   
   1. Many chips forget to colorize the idle stack, this patch fix the bug without any bad side effect.
   2. The common coloration isn't too late than the manual colorization from @Donny9 's report.
   ```
   void nx_start(void)-------------------------------------------------->manual colorization before this
   {
   ...........................
         /* Initialize the 1st processor-specific portion of the TCB
          * Note: other idle thread get initialized in nx_smpstart
          */
   
         if (cpu == 0)
           {
             up_initial_state(&g_idletcb[cpu].cmn);------------------------------------>common colorization here
             up_stack_frame(&g_idletcb[cpu].cmn, sizeof(struct task_info_s));
           }
       }
   
   ```
   The code before up_initial_state is very simple(initialize the link list and global variable), there isn't much difference with these two methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org