You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/09/02 15:15:43 UTC
Re: Review Request 61343: Supported finding the correct subversion
libraries on macOS.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61343/#review184426
-----------------------------------------------------------
Ship it!
Mirrors logic in FindApr.cmake.
3rdparty/stout/cmake/FindSvn.cmake
Lines 19-22 (patched)
<https://reviews.apache.org/r/61343/#comment260603>
Going to add:
```
# NOTE: If this fails, stderr is ignored, and the output variable is empty.
# This has no deleterious effect on our path search.
```
- Joseph Wu
On Aug. 1, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61343/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:59 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This prefers the `brew` subversion package on macOS over the system
> libraries.
>
>
> Diffs
> -----
>
> 3rdparty/stout/cmake/FindSvn.cmake 63aff9d91041edc861a655562f085e50f7d1e881
>
>
> Diff: https://reviews.apache.org/r/61343/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>