[GitHub] TisonKun opened a new pull request #7762: [FLINK-11146] Remove invalid codes in ClusterClient

[GitBox <gi...@apache.org>]

TisonKun opened a new pull request #7762: [FLINK-11146] Remove invalid codes in ClusterClient
URL: https://github.com/apache/flink/pull/7762
 
 
   ## What is the purpose of the change
   
   **DO NOT MERGE(SEE SECTION 3)**
   
   Remove invalid codes in `ClusterClient`.
   
   This pr is aimed at dropping actor/message dependencies in `ClusterClient`. Mainly. it does
   
   1. Delete implementation of following methods and make them `abstract`, because they are implemented by `MiniClusterClient` and `RestClusterClient`, and the implementation in `ClusterClient` depends on legacy logic and thus is invalid. METHODS include 
     - getJobStatus(jobID)
     - cancel(jobID)
     - cancelWithSavepoint(jobID, savepointDir)
     - stop(jobID)
     - triggerSavepoint(jobID, savepointDir)
     - disposeSavepoint(savepointPath)
     - listJobs()
     - getAccumulators(jobID, ClassLoader) 
   
   2. Delete several legacy abstract methods. Since the implementations are simply return a literal None value. Also delete their use points, which includes
     - logAndSysout(String message)
     - waitForClusterToBeReady() 
     - getClusterStatus()
     - getNewMessages()
     - getMaxSlots()
     - hasUserJarsInClassPath(List<URL> userJarFiles)
   
   3. There is still one method depend on legacy mode but I am not sure if we can directly remove it or should be there a port. It is `endSession(JobID jobID)`. I can see now the message(`JobManagerMessages.RemoveCachedJob`) it sends is no one processes it and thus guess that we can directly remove this method as well as its use point in `ContextEnvironment` and `RemoteExecutor`. But I think it is necessary to involve a committer who know how this logic works to confirm that we can do that.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector:(no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   cc @tillrohrmann @mxm 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services