[GitHub] [incubator-hudi] hmatu commented on a change in pull request #1207: [HUDI-458] Redo hudi-hadoop-mr log statements using SLF4J

[GitBox <gi...@apache.org>]

hmatu commented on a change in pull request #1207: [HUDI-458] Redo hudi-hadoop-mr log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1207#discussion_r365496893
 
 

 ##########
 File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java
 ##########
 @@ -101,15 +100,15 @@ public boolean accept(Path path) {
       // Try to use the caches.
       if (nonHoodiePathCache.contains(folder.toString())) {
         if (LOG.isDebugEnabled()) {
-          LOG.debug("Accepting non-hoodie path from cache: " + path);
+          LOG.debug("Accepting non-hoodie path from cache: {}", path);
         }
         return true;
       }
 
       if (hoodiePathCache.containsKey(folder.toString())) {
         if (LOG.isDebugEnabled()) {
-          LOG.debug(String.format("%s Hoodie path checked against cache, accept => %s \n", path,
-              hoodiePathCache.get(folder.toString()).contains(path)));
+          LOG.debug("{} Hoodie path checked against cache, accept => {} \n", path,
 
 Review comment:
   Remove `\n`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services