You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2006/03/27 16:55:32 UTC
Re: [jira] Resolved: (HARMONY-167) java.io.ObjectStreamField.getUnshared() should be isUnshared()
The patch has been applied perfectly. However, I'd failed to spot
that the old method was missing the crucial public keyword when I
wrote the patch to rename it. Adding that would fix it properly.
-Mark.
On 3/27/06, Tim Ellison (JIRA) <ji...@apache.org> wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-167?page=all ]
>
> Tim Ellison resolved HARMONY-167:
> ---------------------------------
>
> Resolution: Fixed
>
> Thanks Mark,
>
> Fix applied to LUNI component
> java.io.ObjectInputStream
> java.io.ObjectOutputStream
> java.io.ObjectStreamField
> at repo revision 389154.
>
> Please check that the patch was applied as you expected.
>
>
> > java.io.ObjectStreamField.getUnshared() should be isUnshared()
> > --------------------------------------------------------------
> >
> > Key: HARMONY-167
> > URL: http://issues.apache.org/jira/browse/HARMONY-167
> > Project: Harmony
> > Type: Bug
> > Components: Classlib
> > Reporter: Mark Hindess
> > Assignee: Tim Ellison
> > Priority: Minor
> > Attachments: getunshared.should.be.isunshared.diff
> >
> > According to the spec there should be an isUnshared() method. There is a getUnshared() method which isn't in the spec so I assume this is an error? Will attach a patch.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
Re: [jira] Resolved: (HARMONY-167) java.io.ObjectStreamField.getUnshared()
should be isUnshared()
Posted by Tim Ellison <t....@gmail.com>.
Good catch!, fixed at repo revision 389162.
Regards,
Tim
Mark Hindess wrote:
> The patch has been applied perfectly. However, I'd failed to spot
> that the old method was missing the crucial public keyword when I
> wrote the patch to rename it. Adding that would fix it properly.
>
> -Mark.
>
> On 3/27/06, Tim Ellison (JIRA) <ji...@apache.org> wrote:
>> [ http://issues.apache.org/jira/browse/HARMONY-167?page=all ]
>>
>> Tim Ellison resolved HARMONY-167:
>> ---------------------------------
>>
>> Resolution: Fixed
>>
>> Thanks Mark,
>>
>> Fix applied to LUNI component
>> java.io.ObjectInputStream
>> java.io.ObjectOutputStream
>> java.io.ObjectStreamField
>> at repo revision 389154.
>>
>> Please check that the patch was applied as you expected.
>>
>>
>>> java.io.ObjectStreamField.getUnshared() should be isUnshared()
>>> --------------------------------------------------------------
>>>
>>> Key: HARMONY-167
>>> URL: http://issues.apache.org/jira/browse/HARMONY-167
>>> Project: Harmony
>>> Type: Bug
>>> Components: Classlib
>>> Reporter: Mark Hindess
>>> Assignee: Tim Ellison
>>> Priority: Minor
>>> Attachments: getunshared.should.be.isunshared.diff
>>>
>>> According to the spec there should be an isUnshared() method. There is a getUnshared() method which isn't in the spec so I assume this is an error? Will attach a patch.
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the administrators:
>> http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.