[GitHub] [qpid-jms] franz1981 commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

[GitBox <gi...@apache.org>]

franz1981 commented on pull request #45:
URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1056916847


   > The same 'this seems overly complex' comment would seem to apply around the pooling of the group, which seems like a large amount of complex handling for what is essentially a very simple 'Is there currently another connection not yet fully closed down' check.
   
   Yep, impl-wise it could be implemented with a single shared (and synchronized) pool, but API-wise things shouldn't change, unless a shared Pool API would handle releasing resources (but that means that Pool should check if such resources belong to it, while the `Ref::close` approach simplify it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org